Review, publish, preview and undo changes through the API

Revisions now call publishing only what publishes: a project's status is
whether the work is active, and a service is published by its flag.

The fake identity server answers by token, so a test can sign in a second
person.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-01 08:29:48 +02:00
parent 4c4a2b3299
commit 5b46436641
18 changed files with 1899 additions and 13 deletions

View File

@@ -0,0 +1,29 @@
<?php
declare(strict_types=1);
namespace App\Http\Controllers\Api\V1\Concerns;
use App\Support\AdminContent;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\Request;
/**
* For the endpoints shared by several kinds of content —
* `/pages/{page}/revisions`, `/projects/{project}/revisions` — whose route
* says which kind through its `content` default.
*/
trait ResolvesContent
{
protected function content(Request $request): string
{
return (string) $request->route('content');
}
protected function record(Request $request): Model
{
$content = $this->content($request);
return AdminContent::find($content, $request->route(AdminContent::parameter($content)));
}
}

View File

@@ -0,0 +1,43 @@
<?php
declare(strict_types=1);
namespace App\Http\Controllers\Api\V1;
use App\Http\Controllers\Api\V1\Concerns\ResolvesContent;
use App\Http\Controllers\Controller;
use App\Support\AdminContent;
use App\Support\PreviewLink;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
/**
* Links to see a draft on the real site, one per language it has an address
* in — the panel's preview button. Each opens that one record only, and stops
* working after `PreviewLink::HOURS`.
*/
class PreviewController extends Controller
{
use ResolvesContent;
public function store(Request $request): JsonResponse
{
$record = $this->record($request);
$this->authorize('view', $record);
$type = AdminContent::PREVIEWABLE[$this->content($request)];
$links = collect(array_keys((array) config('locales.supported')))
->mapWithKeys(fn (string $locale) => [$locale => PreviewLink::for($record, $type, $locale)])
->filter()
->all();
return response()->json([
'data' => [
'links' => (object) $links,
'expires_at' => now()->addHours(PreviewLink::HOURS)->toIso8601String(),
],
], 201);
}
}

View File

@@ -0,0 +1,187 @@
<?php
declare(strict_types=1);
namespace App\Http\Controllers\Api\V1;
use App\Http\Controllers\Api\V1\Concerns\ResolvesContent;
use App\Http\Controllers\Controller;
use App\Http\Resources\ReviewCommentResource;
use App\Models\User;
use App\Support\AdminContent;
use App\Support\ContentTypes;
use App\Support\Publisher;
use Carbon\CarbonImmutable;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
use Illuminate\Validation\ValidationException;
/**
* The handover between writing something and putting it on the site — the
* panel's review buttons, as calls. Pages, projects and services only: the
* kinds with a separate `publish` permission.
*/
class ReviewController extends Controller
{
use ResolvesContent;
/**
* What is waiting for the caller: everything awaiting review they could
* answer, either addressed to them or to nobody in particular.
*/
public function queue(Request $request): JsonResponse
{
$user = $request->user();
$items = collect();
foreach (array_keys(AdminContent::REVIEWABLE) as $resource) {
$model = AdminContent::model($resource);
if ($user->cannot("{$resource}.publish")) {
continue;
}
$model::query()
->awaitingReviewBy($user)
->with(['reviewRequester', 'reviewer'])
->get()
->each(fn (Model $record) => $items->push($this->summary($resource, $record)));
}
return response()->json([
'data' => $items->sortBy('requested_at')->values(),
]);
}
/**
* The thread: requests, returns, publications and comments, newest first.
*/
public function thread(Request $request): AnonymousResourceCollection
{
$record = $this->record($request);
$this->authorize('view', $record);
return ReviewCommentResource::collection(
$record->reviewComments()->with('user')->paginate(perPage: min($request->integer('per_page', 25), 100)),
);
}
/**
* Ask for it to be reviewed — the only way somebody without the publish
* permission has of putting their work live.
*/
public function request(Request $request): JsonResponse
{
$record = $this->record($request);
$this->authorize('update', $record);
$data = $request->validate([
'reviewer_id' => ['sometimes', 'nullable', 'integer', 'exists:users,id'],
'note' => ['sometimes', 'nullable', 'string', 'max:2000'],
]);
if ($record->isAwaitingReview() || $record->isPublishedNow()) {
throw ValidationException::withMessages(['review' => [__('rules.reviews.not_requestable')]]);
}
$reviewer = isset($data['reviewer_id']) ? User::find($data['reviewer_id']) : null;
if ($reviewer !== null && $reviewer->cannot($record->getTable().'.publish')) {
throw ValidationException::withMessages(['reviewer_id' => [__('rules.reviews.not_a_reviewer')]]);
}
$record->requestReview($reviewer, $data['note'] ?? null, $request->user());
return $this->answer($record);
}
/**
* Send it back to whoever asked, saying why.
*/
public function return(Request $request): JsonResponse
{
$record = $this->record($request);
$this->authorize($record->getTable().'.publish');
$data = $request->validate(['note' => ['required', 'string', 'max:2000']]);
if (! $record->isAwaitingReview()) {
throw ValidationException::withMessages(['review' => [__('rules.reviews.not_awaiting')]]);
}
$record->returnForChanges($data['note'], $request->user());
return $this->answer($record);
}
public function comment(Request $request): JsonResponse
{
$record = $this->record($request);
$this->authorize('view', $record);
$data = $request->validate(['body' => ['required', 'string', 'max:2000']]);
return ReviewCommentResource::make($record->comment($data['body'], $request->user())->load('user'))
->response()
->setStatusCode(201);
}
/**
* Approve: on the site now, or from `at`. Either way the review, if there
* was one, is answered.
*/
public function publish(Request $request): JsonResponse
{
$record = $this->record($request);
$this->authorize($record->getTable().'.publish');
$data = $request->validate(['at' => ['sometimes', 'nullable', 'date']]);
Publisher::publish($record, filled($data['at'] ?? null) ? CarbonImmutable::parse($data['at']) : null);
return $this->answer($record);
}
public function unpublish(Request $request): JsonResponse
{
$record = $this->record($request);
$this->authorize($record->getTable().'.publish');
Publisher::unpublish($record);
return $this->answer($record);
}
protected function answer(Model $record): JsonResponse
{
$record->refresh()->load(['reviewRequester', 'reviewer']);
return response()->json(['data' => $this->summary(AdminContent::nameOf($record), $record)]);
}
/**
* @return array<string, mixed>
*/
protected function summary(string $resource, Model $record): array
{
return [
'type' => $resource,
'id' => $record->getKey(),
'title' => ContentTypes::title($record),
'published' => $record->isPublishedNow(),
'published_at' => $record->published_at?->toIso8601String(),
'awaiting_review' => $record->isAwaitingReview(),
'requested_at' => $record->review_requested_at?->toIso8601String(),
'requested_by' => $record->reviewRequester ? ['id' => $record->reviewRequester->id, 'name' => $record->reviewRequester->name] : null,
'reviewer' => $record->reviewer ? ['id' => $record->reviewer->id, 'name' => $record->reviewer->name] : null,
];
}
}

View File

@@ -0,0 +1,74 @@
<?php
declare(strict_types=1);
namespace App\Http\Controllers\Api\V1;
use App\Http\Controllers\Api\V1\Concerns\ResolvesContent;
use App\Http\Controllers\Controller;
use App\Http\Resources\RevisionResource;
use App\Models\Revision;
use App\Support\AdminContent;
use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\AnonymousResourceCollection;
use Illuminate\Validation\ValidationException;
/**
* A record's history: who changed what and when, and undoing one change.
*/
class RevisionController extends Controller
{
use ResolvesContent;
/**
* Newest first. Filter: event.
*/
public function index(Request $request): AnonymousResourceCollection
{
$record = $this->record($request);
$this->authorize('view', $record);
$revisions = $record->revisions()
->with('user')
->when($request->filled('event'), fn ($q) => $q->where('event', $request->string('event')))
->paginate(perPage: min($request->integer('per_page', 25), 100))
->withQueryString();
return RevisionResource::collection($revisions);
}
/**
* Put back what one revision changed, as the panel's history does.
* Restoring is itself a change, so it lands in the history too — the way
* back is never lost.
*/
public function restore(Request $request, Revision $revision): RevisionResource
{
$model = Relation::getMorphedModel($revision->revisionable_type) ?? $revision->revisionable_type;
$record = AdminContent::findOf($model, $revision->revisionable_id);
$this->authorize('update', $record);
$values = $revision->previousValues();
if ($values === []) {
throw ValidationException::withMessages(['revision' => [__('rules.revisions.nothing_to_restore')]]);
}
// Undoing a change can publish or unpublish, and that stays with whoever
// may publish.
$guarded = array_intersect(array_keys($values), AdminContent::publicationFields($record));
if ($guarded !== [] && $request->user()->cannot($record->getTable().'.publish')) {
throw ValidationException::withMessages(['revision' => [__('rules.publication.forbidden')]]);
}
// Only what the model lets a form write: a revision may mention
// bookkeeping columns, and those are not anybody's to put back.
$record->forceFill(array_intersect_key($values, array_flip($record->getFillable())))->save();
return RevisionResource::make($record->revisions()->with('user')->first());
}
}