Upload images through the API, and from the MCP server
Some checks failed
Tests / lint (push) Has been cancelled
Tests / test (push) Has been cancelled
Tests / test-postgres (push) Has been cancelled
Tests / mcp (push) Has been cancelled

POST /api/v1/media stores an image where the panel keeps a page's and
answers with the path to send as `featured_image`. Without it the MCP
server could create a page but never give it a picture. The file goes
through Media::for(), so it is processed, served and pruned like one
uploaded in the panel.

Two ways in, one per request: a multipart `file`, or JSON with a `url`
the API downloads itself. JPEG, PNG, WebP, GIF or AVIF only, decided
from the bytes; no SVG, which is a document that can carry script.

The URL is fetched from inside the stack's network, so RemoteImage
guards it: HTTPS only, every resolved address must be public, the
connection is pinned to the checked address with CURLOPT_RESOLVE so a
changing DNS answer cannot swap in a private one, redirects are not
followed, and the body is read to a ceiling whatever its headers say.

Uploading needs permission to write pages. MediaPolicy::create stays
false, so the panel gains no free-standing "new file" button.

In the MCP server a multipart binary field becomes `<field>_path` over
stdio: the server reads the file from the caller's disk and sends it
as multipart, instead of the model pushing base64 through its context.
Over HTTP the server's disk is not the caller's, so only `body.url` is
offered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-09-28 11:16:33 +02:00
parent daf6098203
commit a49816eb46
21 changed files with 1008 additions and 11 deletions

View File

@@ -1,4 +1,7 @@
import assert from 'node:assert/strict';
import { mkdtemp, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { test } from 'node:test';
import { LandingClient } from '../src/client.mjs';
@@ -149,3 +152,47 @@ test('refuses a call missing a path parameter', async () => {
await assert.rejects(client.call(showPage, {}), /"page"/);
});
const uploadMedia = {
method: 'POST',
path: '/v1/media',
params: [],
hasBody: true,
files: ['file'],
requiresAuth: true,
};
test('uploads a local file as multipart, never as JSON', async () => {
const dir = await mkdtemp(join(tmpdir(), 'landing-mcp-'));
const file = join(dir, 'hero.png');
await writeFile(file, Buffer.from([0x89, 0x50, 0x4e, 0x47]));
const { fetch, calls } = fakeFetch(() => ({ status: 201, body: { data: { path: 'pages/x.png' } } }));
const client = new LandingClient({ apiBase: 'http://app.test/api', token: 't', fetch });
const response = await client.call(uploadMedia, { file_path: file });
const sent = calls[0].body;
assert.equal(response.status, 201);
assert.ok(sent instanceof FormData);
assert.equal(sent.get('file').name, 'hero.png');
assert.equal(sent.get('file').size, 4);
// fetch has to write it, boundary and all.
assert.equal(calls[0].headers['Content-Type'], undefined);
});
test('sends the JSON body when there is no file', async () => {
const { fetch, calls } = fakeFetch(() => ({ status: 201, body: {} }));
const client = new LandingClient({ apiBase: 'http://app.test/api', token: 't', fetch });
await client.call(uploadMedia, { body: { url: 'https://images.example.org/a.png' } });
assert.equal(calls[0].headers['Content-Type'], 'application/json');
assert.equal(JSON.parse(calls[0].body).url, 'https://images.example.org/a.png');
});
test('says which file it could not read', async () => {
const client = new LandingClient({ apiBase: 'http://app.test/api', token: 't', fetch: async () => assert.fail('no request') });
await assert.rejects(client.call(uploadMedia, { file_path: '/nope/missing.png' }), /\/nope\/missing\.png/);
});