refactor(api): buses only in services, atomic commands, @Prop schemas
- Mongo read models are @Schema/@Prop classes (SchemaFactory), still loose: the props declared are the indexed or shaped ones. - CommandBus and QueryBus are used by the application services alone. Duplicating a ticket, bulk updates, CSV imports, proposals and emptying the trash chain several commands, so they are service methods now and their composite commands are gone; every command handler is atomic. No forwardRef is needed. - The due-date and trash timers are entry points: they live in the presenters and call the services. The automations event handler has its own file and calls AutomationsService. - The tracker's user directory asks IdentityService; the composition root hands the identity application module to the tracker infrastructure (withIdentity), with no global module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,18 +1,25 @@
|
||||
import {
|
||||
ProposalKind,
|
||||
SubmitProposalCommand,
|
||||
} from './commands/submit-proposal.command';
|
||||
import { GetShowcaseQuery, Showcase } from './queries/get-showcase.query';
|
||||
import { Injectable } from '@nestjs/common';
|
||||
import { CommandBus, QueryBus } from '@nestjs/cqrs';
|
||||
import {
|
||||
ForbiddenError,
|
||||
NotFoundError,
|
||||
assertThat,
|
||||
} from '@task-stream/api/shared/domain';
|
||||
import {
|
||||
IssuePriority,
|
||||
ProjectAnalyticsReadModel,
|
||||
ProjectReadModel,
|
||||
ProjectRole,
|
||||
ProjectSettings,
|
||||
ProjectStatsReadModel,
|
||||
ReleaseReadModel,
|
||||
SYSTEM_ACTOR_ID,
|
||||
} from '@task-stream/api/tracker/domain';
|
||||
import { CreateIssueCommand } from './commands/create-issue.command';
|
||||
import { WriteAccess } from './commands/write-access';
|
||||
import { FindProjectsRepository } from './ports/find-projects.repository';
|
||||
import { PROPOSAL_LABEL, PROPOSAL_TYPE, ProposalKind } from './proposals';
|
||||
import { AddProjectMemberCommand } from './commands/add-project-member.command';
|
||||
import { ChangeProjectMemberRoleCommand } from './commands/change-project-member-role.command';
|
||||
import { CommandResult } from './commands/command-result';
|
||||
@@ -35,22 +42,68 @@ export class ProjectsService {
|
||||
constructor(
|
||||
private readonly commandBus: CommandBus,
|
||||
private readonly queryBus: QueryBus,
|
||||
private readonly findProjects: FindProjectsRepository,
|
||||
private readonly access: WriteAccess,
|
||||
) {}
|
||||
|
||||
/** A public project's roadmap, releases, sprint and good first tickets (no token). */
|
||||
/** A bug report or an idea from anyone, for a public project that takes them. */
|
||||
propose(
|
||||
project: string,
|
||||
/**
|
||||
* A bug report or an idea from anyone, for a public project that takes
|
||||
* them. It becomes a ticket labelled «propuesta», opened by TaskStream
|
||||
* (nobody signed in) in the first status, as a Bug or a Feature (or the
|
||||
* first active type if the project has neither), signed with the name
|
||||
* they gave, if any.
|
||||
*/
|
||||
async propose(
|
||||
projectIdOrKey: string,
|
||||
kind: ProposalKind,
|
||||
title: string,
|
||||
description: string,
|
||||
author: string | null,
|
||||
): Promise<CommandResult> {
|
||||
const found =
|
||||
(await this.findProjects.findById(projectIdOrKey)) ??
|
||||
(await this.findProjects.findByKey(projectIdOrKey.toUpperCase()));
|
||||
if (!found?.isPublic) throw new NotFoundError('Project', projectIdOrKey);
|
||||
if (!found.acceptsProposals)
|
||||
throw new ForbiddenError(`${found.key} does not take proposals`);
|
||||
|
||||
const cleanTitle = title.trim();
|
||||
assertThat(
|
||||
cleanTitle.length >= 3 && cleanTitle.length <= 150,
|
||||
'A proposal needs a title of 3 to 150 characters',
|
||||
);
|
||||
const text = description.trim();
|
||||
assertThat(text.length <= 5000, 'A proposal is 5000 characters at most');
|
||||
|
||||
const project = await this.access.project(found.id);
|
||||
const active = project.settings.issueTypes.filter((t) => !t.archived);
|
||||
const type =
|
||||
active.find((t) => t.id === PROPOSAL_TYPE[kind])?.id ?? active[0]?.id;
|
||||
const signer = author?.trim().slice(0, 80);
|
||||
const signature = `_Propuesta enviada desde el formulario público${signer ? ` por ${signer}` : ''}._`;
|
||||
|
||||
return this.commandBus.execute(
|
||||
new SubmitProposalCommand(project, kind, title, description, author),
|
||||
new CreateIssueCommand(
|
||||
SYSTEM_ACTOR_ID,
|
||||
project.id,
|
||||
type,
|
||||
cleanTitle,
|
||||
{
|
||||
description: text ? `${text}\n\n${signature}` : signature,
|
||||
labels: [PROPOSAL_LABEL],
|
||||
priority: IssuePriority.MEDIUM,
|
||||
},
|
||||
null,
|
||||
null,
|
||||
null,
|
||||
null,
|
||||
// What they wrote is the content, not the type's template.
|
||||
false,
|
||||
),
|
||||
);
|
||||
}
|
||||
|
||||
/** A public project's roadmap, releases, sprint and good first tickets (no token). */
|
||||
showcase(project: string): Promise<Showcase> {
|
||||
return this.queryBus.execute(new GetShowcaseQuery(project));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user