feat: what is new since my last visit, and turning a comment into a ticket

Opening a ticket notes the visit and answers the one before (issue_visits),
so the page marks others' comments and changes since. A comment can become
a ticket of its own, as a subtask or linked; it remembers where it went.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-21 21:05:44 +02:00
parent 429b52e6f5
commit 285bd5c454
50 changed files with 1953 additions and 79 deletions

View File

@@ -3683,6 +3683,108 @@
] ]
} }
}, },
"/api/issues/{issue}/visit": {
"put": {
"description": "Answers when I had opened it before (null: never), to show what others did since. Private to me.",
"operationId": "IssuesController_visit",
"parameters": [
{
"name": "issue",
"required": true,
"in": "path",
"description": "Ticket id or key",
"schema": {
"example": "WEB-12",
"type": "string"
}
}
],
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/IssueVisitDto"
}
}
}
},
"400": {
"description": "Invalid input",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"401": {
"description": "Missing or rejected Pireon token",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"403": {
"description": "Not a member of the project (or not allowed)",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"404": {
"description": "Not found",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"409": {
"description": "Someone changed it at the same time: retry",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"422": {
"description": "Business rule (e.g. a transition the workflow forbids)",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
}
},
"security": [
{
"pireon-oauth": []
},
{
"pireon": []
}
],
"summary": "I opened this ticket now",
"tags": [
"Issues"
]
}
},
"/api/issues/{issue}/follow-tree": { "/api/issues/{issue}/follow-tree": {
"put": { "put": {
"description": "Told of its changes and of every ticket hanging from it, at any depth, also the ones added later. Private to me.", "description": "Told of its changes and of every ticket hanging from it, at any depth, also the ones added later. Private to me.",
@@ -8436,6 +8538,116 @@
] ]
} }
}, },
"/api/comments/{commentId}/issue": {
"post": {
"description": "Its text becomes the description, as a subtask of its ticket or linked to it (RELATES_TO); the comment shows where it went. Answers the new ticket. Whoever can change tickets.",
"operationId": "CommentsController_turnIntoIssue",
"parameters": [
{
"name": "commentId",
"required": true,
"in": "path",
"schema": {
"type": "string"
}
}
],
"requestBody": {
"required": true,
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/TurnCommentIntoIssueDto"
}
}
}
},
"responses": {
"200": {
"description": "",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/CommandResultDto"
}
}
}
},
"400": {
"description": "Invalid input",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"401": {
"description": "Missing or rejected Pireon token",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"403": {
"description": "Not a member of the project (or not allowed)",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"404": {
"description": "Not found",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"409": {
"description": "Someone changed it at the same time: retry",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
},
"422": {
"description": "Business rule (e.g. a transition the workflow forbids)",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/ApiErrorDto"
}
}
}
}
},
"security": [
{
"pireon-oauth": []
},
{
"pireon": []
}
],
"summary": "Make a ticket of a comment",
"tags": [
"Comments"
]
}
},
"/api/comments/{commentId}/resolution": { "/api/comments/{commentId}/resolution": {
"put": { "put": {
"description": "Whoever can change the ticket. A conclusion is added as a reply marked as a decision. The web folds a settled conversation.", "description": "Whoever can change the ticket. A conclusion is added as a reply marked as a decision. The web folds a settled conversation.",
@@ -17708,6 +17920,20 @@
"verdict" "verdict"
] ]
}, },
"IssueVisitDto": {
"type": "object",
"properties": {
"previousVisit": {
"type": "string",
"format": "date-time",
"nullable": true,
"description": "My visit before this one (null: first time)"
}
},
"required": [
"previousVisit"
]
},
"IssuePageDto": { "IssuePageDto": {
"type": "object", "type": "object",
"properties": { "properties": {
@@ -18190,6 +18416,22 @@
"winner" "winner"
] ]
}, },
"CommentSpawnDto": {
"type": "object",
"properties": {
"id": {
"type": "string"
},
"key": {
"type": "string",
"example": "WEB-45"
}
},
"required": [
"id",
"key"
]
},
"CommentDto": { "CommentDto": {
"type": "object", "type": "object",
"properties": { "properties": {
@@ -18272,6 +18514,13 @@
"nullable": true, "nullable": true,
"format": "date-time" "format": "date-time"
}, },
"spawned": {
"description": "Tickets made from it («Convertir en ticket»), oldest first",
"type": "array",
"items": {
"$ref": "#/components/schemas/CommentSpawnDto"
}
},
"createdAt": { "createdAt": {
"type": "string", "type": "string",
"format": "date-time" "format": "date-time"
@@ -18300,6 +18549,7 @@
"resolved", "resolved",
"resolvedBy", "resolvedBy",
"resolvedAt", "resolvedAt",
"spawned",
"createdAt", "createdAt",
"editedAt", "editedAt",
"version" "version"
@@ -18476,6 +18726,29 @@
} }
} }
}, },
"TurnCommentIntoIssueDto": {
"type": "object",
"properties": {
"title": {
"type": "string",
"example": "También falla en Android",
"maxLength": 200
},
"type": {
"type": "string",
"description": "One of the project's ticket type ids"
},
"asSubtask": {
"type": "boolean",
"default": false,
"description": "Hang it from the ticket of the comment; otherwise it is linked to it (RELATES_TO)"
}
},
"required": [
"title",
"type"
]
},
"ResolveThreadDto": { "ResolveThreadDto": {
"type": "object", "type": "object",
"properties": { "properties": {

View File

@@ -318,6 +318,9 @@ type Comment {
"""Who settled it""" """Who settled it"""
resolvedBy: UserRef resolvedBy: UserRef
"""Tickets made from it («Convertir en ticket»), oldest first"""
spawned: [CommentSpawn!]!
version: Int! version: Int!
} }
@@ -354,6 +357,12 @@ type CommentReaction {
users: [UserRef!]! users: [UserRef!]!
} }
"""A ticket made from a comment"""
type CommentSpawn {
id: ID!
key: String!
}
type CountByAssignee { type CountByAssignee {
count: Int! count: Int!
@@ -1209,6 +1218,18 @@ type Mutation {
""" """
trashIssue(issueId: ID!): CommandResult! trashIssue(issueId: ID!): CommandResult!
"""
Make a ticket of a comment: its text becomes the description, as a subtask of its ticket or linked to it (RELATES_TO). Answers the new ticket. Whoever can change tickets
"""
turnCommentIntoIssue(
asSubtask: Boolean! = false
commentId: ID!
title: String!
"""One of the project's ticket type ids"""
type: String!
): CommandResult!
""" """
I am writing on this ticket (send every few seconds while typing): those with it open see it at once via `typing` I am writing on this ticket (send every few seconds while typing): those with it open see it at once via `typing`
""" """
@@ -1258,6 +1279,11 @@ type Mutation {
updateSprint(input: UpdateSprintInput!): CommandResult! updateSprint(input: UpdateSprintInput!): CommandResult!
updateWebhook(input: UpdateWebhookInput!): Webhook! updateWebhook(input: UpdateWebhookInput!): Webhook!
"""
I opened this ticket now: answers when I had opened it before (null: never), to show what is new since
"""
visitIssue(issueId: ID!): String
""" """
Vote for a ticket (on) or take the vote back: anyone signed in on a public project, members on a private one Vote for a ticket (on) or take the vote back: anyone signed in on a public project, members on a private one
""" """

View File

@@ -632,6 +632,26 @@ export interface paths {
patch?: never; patch?: never;
trace?: never; trace?: never;
}; };
"/api/issues/{issue}/visit": {
parameters: {
query?: never;
header?: never;
path?: never;
cookie?: never;
};
get?: never;
/**
* I opened this ticket now
* @description Answers when I had opened it before (null: never), to show what others did since. Private to me.
*/
put: operations["IssuesController_visit"];
post?: never;
delete?: never;
options?: never;
head?: never;
patch?: never;
trace?: never;
};
"/api/issues/{issue}/follow-tree": { "/api/issues/{issue}/follow-tree": {
parameters: { parameters: {
query?: never; query?: never;
@@ -1241,6 +1261,26 @@ export interface paths {
patch?: never; patch?: never;
trace?: never; trace?: never;
}; };
"/api/comments/{commentId}/issue": {
parameters: {
query?: never;
header?: never;
path?: never;
cookie?: never;
};
get?: never;
put?: never;
/**
* Make a ticket of a comment
* @description Its text becomes the description, as a subtask of its ticket or linked to it (RELATES_TO); the comment shows where it went. Answers the new ticket. Whoever can change tickets.
*/
post: operations["CommentsController_turnIntoIssue"];
delete?: never;
options?: never;
head?: never;
patch?: never;
trace?: never;
};
"/api/comments/{commentId}/resolution": { "/api/comments/{commentId}/resolution": {
parameters: { parameters: {
query?: never; query?: never;
@@ -3181,6 +3221,13 @@ export interface components {
verdict: components["schemas"]["ReviewVerdict"]; verdict: components["schemas"]["ReviewVerdict"];
answer?: string; answer?: string;
}; };
IssueVisitDto: {
/**
* Format: date-time
* @description My visit before this one (null: first time)
*/
previousVisit: string | null;
};
IssuePageDto: { IssuePageDto: {
items: components["schemas"]["IssueDto"][]; items: components["schemas"]["IssueDto"][];
/** @description Total matches (for pagination) */ /** @description Total matches (for pagination) */
@@ -3377,6 +3424,11 @@ export interface components {
/** @description Index of the winning option once closed (null on a tie) */ /** @description Index of the winning option once closed (null on a tie) */
winner: number | null; winner: number | null;
}; };
CommentSpawnDto: {
id: string;
/** @example WEB-45 */
key: string;
};
CommentDto: { CommentDto: {
/** Format: uuid */ /** Format: uuid */
id: string; id: string;
@@ -3407,6 +3459,8 @@ export interface components {
resolvedBy: components["schemas"]["UserRefDto"] | null; resolvedBy: components["schemas"]["UserRefDto"] | null;
/** Format: date-time */ /** Format: date-time */
resolvedAt: string | null; resolvedAt: string | null;
/** @description Tickets made from it («Convertir en ticket»), oldest first */
spawned: components["schemas"]["CommentSpawnDto"][];
/** Format: date-time */ /** Format: date-time */
createdAt: string; createdAt: string;
/** Format: date-time */ /** Format: date-time */
@@ -3490,6 +3544,17 @@ export interface components {
*/ */
decide: boolean; decide: boolean;
}; };
TurnCommentIntoIssueDto: {
/** @example También falla en Android */
title: string;
/** @description One of the project's ticket type ids */
type: string;
/**
* @description Hang it from the ticket of the comment; otherwise it is linked to it (RELATES_TO)
* @default false
*/
asSubtask: boolean;
};
ResolveThreadDto: { ResolveThreadDto: {
/** @description What was settled: added as a reply marked as a decision before it closes */ /** @description What was settled: added as a reply marked as a decision before it closes */
conclusion?: string; conclusion?: string;
@@ -6732,6 +6797,82 @@ export interface operations {
}; };
}; };
}; };
IssuesController_visit: {
parameters: {
query?: never;
header?: never;
path: {
/** @description Ticket id or key */
issue: string;
};
cookie?: never;
};
requestBody?: never;
responses: {
200: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["IssueVisitDto"];
};
};
/** @description Invalid input */
400: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Missing or rejected Pireon token */
401: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Not a member of the project (or not allowed) */
403: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Not found */
404: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Someone changed it at the same time: retry */
409: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Business rule (e.g. a transition the workflow forbids) */
422: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
};
};
IssuesController_followTree: { IssuesController_followTree: {
parameters: { parameters: {
query?: never; query?: never;
@@ -9935,6 +10076,85 @@ export interface operations {
}; };
}; };
}; };
CommentsController_turnIntoIssue: {
parameters: {
query?: never;
header?: never;
path: {
commentId: string;
};
cookie?: never;
};
requestBody: {
content: {
"application/json": components["schemas"]["TurnCommentIntoIssueDto"];
};
};
responses: {
200: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["CommandResultDto"];
};
};
/** @description Invalid input */
400: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Missing or rejected Pireon token */
401: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Not a member of the project (or not allowed) */
403: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Not found */
404: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Someone changed it at the same time: retry */
409: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
/** @description Business rule (e.g. a transition the workflow forbids) */
422: {
headers: {
[name: string]: unknown;
};
content: {
"application/json": components["schemas"]["ApiErrorDto"];
};
};
};
};
CommentsController_resolveThread: { CommentsController_resolveThread: {
parameters: { parameters: {
query?: never; query?: never;

View File

@@ -599,6 +599,37 @@ export class IssuesResolver {
); );
} }
@Tool({
name: 'turn_comment_into_issue',
description:
"Make a ticket of a comment that turned out to be work of its own: its text becomes the description, as a subtask of the comment's ticket (asSubtask) or linked to it. Read type ids with get_project. Answers the new ticket's key.",
paramsSchema: z.object({
commentId: z.string().min(1),
title: z.string().min(1).max(200),
type: z.string().min(1).describe("One of the project's ticket type ids"),
asSubtask: z.boolean().default(false),
}),
annotations: WRITE,
})
turnCommentIntoIssue(
{
commentId,
title,
type,
asSubtask,
}: { commentId: string; title: string; type: string; asSubtask: boolean },
ctx: McpContext,
) {
return toolResult(() =>
this.api.data(
this.api.as(ctx).POST('/api/comments/{commentId}/issue', {
params: { path: { commentId } },
body: { title, type, asSubtask },
}),
),
);
}
@Tool({ @Tool({
name: 'link_issues', name: 'link_issues',
description: description:

View File

@@ -3,7 +3,7 @@
## Qué resuelve ## Qué resuelve
| Necesidad | Cómo se resuelve | | Necesidad | Cómo se resuelve |
| --------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | --------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| 🐛 Bugs | Tickets de tipo `BUG` con prioridad, área y etiquetas | | 🐛 Bugs | Tickets de tipo `BUG` con prioridad, área y etiquetas |
| 🌍 Públicos | Un proyecto público se puede leer sin iniciar sesión (web, GraphQL y REST): tablero, tickets, comentarios, releases, actividad y estadísticas; «Explorar» los lista | | 🌍 Públicos | Un proyecto público se puede leer sin iniciar sesión (web, GraphQL y REST): tablero, tickets, comentarios, releases, actividad y estadísticas; «Explorar» los lista |
| 🗑️ Borrar | El propietario borra un proyecto confirmando su clave; tickets, comentarios, releases y enlaces desde otros proyectos se borran en cascada (sagas) y la clave queda libre | | 🗑️ Borrar | El propietario borra un proyecto confirmando su clave; tickets, comentarios, releases y enlaces desde otros proyectos se borran en cascada (sagas) y la clave queda libre |
@@ -14,7 +14,7 @@
| 🚀 Releases | Versiones a las que se asignan tickets; no se publican con tickets sin terminar (salvo forzando) | | 🚀 Releases | Versiones a las que se asignan tickets; no se publican con tickets sin terminar (salvo forzando) |
| 📝 Notas de versión | Borrador en Markdown con los tickets terminados por tipo, editable y copiable, también tras publicar; y una página pública por release para los clientes, con enlace secreto | | 📝 Notas de versión | Borrador en Markdown con los tickets terminados por tipo, editable y copiable, también tras publicar; y una página pública por release para los clientes, con enlace secreto |
| 👥 Asignaciones | Solo a miembros del proyecto; panel de carga por persona | | 👥 Asignaciones | Solo a miembros del proyecto; panel de carga por persona |
| 💬 Comentarios | Decisiones y explicaciones dentro del ticket, con formato (editor visual, guardado en Markdown), capturas pegadas, respuestas, reacciones (👍 🎉…), decisiones (un comentario marcado sale encima del ticket y se encuentra al buscar), conversaciones que se resuelven con su conclusión, encuestas rápidas que acaban en decisión, «está escribiendo…» en vivo y `@menciones`; el autor edita, el admin modera | | 💬 Comentarios | Decisiones y explicaciones dentro del ticket, con formato (editor visual, guardado en Markdown), capturas pegadas, respuestas, reacciones (👍 🎉…), decisiones (un comentario marcado sale encima del ticket y se encuentra al buscar), conversaciones que se resuelven con su conclusión, convertir un comentario en ticket, lo nuevo desde tu última visita marcado, encuestas rápidas que acaban en decisión, «está escribiendo…» en vivo y `@menciones`; el autor edita, el admin modera |
| 🔎 Vistas | El tablero se filtra por texto, persona (o sin asignar), tipo, prioridad, área y release; los filtros se guardan como vistas propias o compartidas con el proyecto | | 🔎 Vistas | El tablero se filtra por texto, persona (o sin asignar), tipo, prioridad, área y release; los filtros se guardan como vistas propias o compartidas con el proyecto |
| 📋 Lista | Todos los tickets en filas: ordenar por cualquier columna, filtrar, cambiar estado, prioridad o persona sin abrirlos, editar en bloque y duplicar | | 📋 Lista | Todos los tickets en filas: ordenar por cualquier columna, filtrar, cambiar estado, prioridad o persona sin abrirlos, editar en bloque y duplicar |
| ↩️ Deshacer | Mover, reasignar o mandar a la papelera ofrece «Deshacer» unos segundos (también Ctrl/⌘ Z), con la orden contraria | | ↩️ Deshacer | Mover, reasignar o mandar a la papelera ofrece «Deshacer» unos segundos (también Ctrl/⌘ Z), con la orden contraria |

View File

@@ -245,6 +245,11 @@ stateDiagram-v2
admin, la cierra (`closePoll(commentId, decide)`, `POST …/poll/close`; `CommentPollClosedEvent`): gana la más votada admin, la cierra (`closePoll(commentId, decide)`, `POST …/poll/close`; `CommentPollClosedEvent`): gana la más votada
(con empate, ninguna) y, con `decide`, se añade una respuesta «Decidido: …» marcada como decisión. El comentario da (con empate, ninguna) y, con `decide`, se añade una respuesta «Decidido: …» marcada como decisión. El comentario da
`poll { options { text voters } closed winner }`. `poll { options { text voters } closed winner }`.
- **Convertir en ticket**: un comentario que resulta ser trabajo propio se convierte en ticket
(`turnCommentIntoIssue(commentId, title, type, asSubtask)`, `POST /api/comments/{id}/issue`), como subtarea del ticket
del comentario o enlazado a él (`RELATES_TO`), por quien puede cambiar tickets. El texto del comentario es la
descripción (sin la plantilla del tipo), con una línea de dónde sale; el comentario lo recuerda
(`CommentTurnedIntoIssueEvent`) y da `spawned { id key }`. Devuelve el ticket nuevo.
- **Conversaciones**: un comentario raíz y sus respuestas se resuelven (`resolveThread(commentId, resolved, conclusion)`, - **Conversaciones**: un comentario raíz y sus respuestas se resuelven (`resolveThread(commentId, resolved, conclusion)`,
`PUT/DELETE /api/comments/{id}/resolution`; evento `CommentThreadResolvedEvent`) por quien puede cambiar el ticket; `PUT/DELETE /api/comments/{id}/resolution`; evento `CommentThreadResolvedEvent`) por quien puede cambiar el ticket;
una respuesta no se resuelve sola. Si trae `conclusion`, antes de cerrarla se añade como respuesta marcada como una respuesta no se resuelve sola. Si trae `conclusion`, antes de cerrarla se añade como respuesta marcada como
@@ -454,7 +459,10 @@ historial (`my_days`). **Recordármelo**: cada persona pone en un ticket un reco
/api/issues/{issue}/reminder`, `GET /api/me/reminders`): uno por ticket, en el futuro y como mucho a un año. Cada minuto /api/issues/{issue}/reminder`, `GET /api/me/reminders`): uno por ticket, en el futuro y como mucho a un año. Cada minuto
`IssueReminderScheduler` avisa de los que tocan (`REMINDER`, por la campana, el navegador y el correo; una vez, por su `IssueReminderScheduler` avisa de los que tocan (`REMINDER`, por la campana, el navegador y el correo; una vez, por su
id) y olvida los de tickets en la papelera o fuera de alcance. Privados y sin historial (`issue_reminders`); id) y olvida los de tickets en la papelera o fuera de alcance. Privados y sin historial (`issue_reminders`);
`REMINDERS_ENABLED=false` los apaga junto con los de fecha límite. **Seguir todo**: seguir un ticket con todo lo que cuelga de él (una épica, un ticket con subtareas): `REMINDERS_ENABLED=false` los apaga junto con los de fecha límite. **Lo nuevo desde tu última visita**: al abrir un
ticket, `visitIssue(issueId)` (`PUT /api/issues/{issue}/visit`) apunta la visita y devuelve la anterior (null la
primera vez); con ella el cliente marca lo que otros han hecho desde entonces. Personal y sin historial (colección
`issue_visits`). **Seguir todo**: seguir un ticket con todo lo que cuelga de él (una épica, un ticket con subtareas):
`followTree`/`unfollowTree`, `Issue.followingTree`; `PUT/DELETE /api/issues/{issue}/follow-tree`. Quien lo hace oye lo `followTree`/`unfollowTree`, `Issue.followingTree`; `PUT/DELETE /api/issues/{issue}/follow-tree`. Quien lo hace oye lo
mismo que un seguidor de cada ticket de debajo, a cualquier profundidad, también de los que se añadan, y además cuándo mismo que un seguidor de cada ticket de debajo, a cualquier profundidad, también de los que se añadan, y además cuándo
uno entra (`IssueParentChangedEvent`). Personal y sin historial (colección `tree_follows`); los invitados de un proyecto uno entra (`IssueParentChangedEvent`). Personal y sin historial (colección `tree_follows`); los invitados de un proyecto
@@ -574,10 +582,10 @@ que funcionan también sin token.
Todas devuelven `CommandResult { id, key, version }`. Todas devuelven `CommandResult { id, key, version }`.
| Ámbito | Mutations | | Ámbito | Mutations |
| ----------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | ----------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| Proyectos | `createProject`, `updateProject`, `updateProjectSettings`, `deleteProject(confirmKey)`, `addProjectMember`, `changeProjectMemberRole`, `removeProjectMember` | | Proyectos | `createProject`, `updateProject`, `updateProjectSettings`, `deleteProject(confirmKey)`, `addProjectMember`, `changeProjectMemberRole`, `removeProjectMember` |
| Tickets | `createIssue`, `updateIssue`, `changeIssueStatus`, `assignIssue`, `linkIssues`, `unlinkIssues`, `setIssueRelease`, `setIssueParent`, `rankIssue`, `addChecklistItem`, `updateChecklistItem`, `removeChecklistItem`, `watchIssue`, `unwatchIssue`, `requestReview`, `answerReview`, `cancelReview`, `pinIssue`, `unpinIssue`, `followTree`, `unfollowTree`, `clearReminder`, `addToMyDay`, `removeFromMyDay` (devuelven `true`), `setReminder`, `removeAttachment` (subir: por REST), `duplicateIssue`, `voteIssue` | | Tickets | `createIssue`, `updateIssue`, `changeIssueStatus`, `assignIssue`, `linkIssues`, `unlinkIssues`, `setIssueRelease`, `setIssueParent`, `rankIssue`, `addChecklistItem`, `updateChecklistItem`, `removeChecklistItem`, `watchIssue`, `unwatchIssue`, `requestReview`, `answerReview`, `cancelReview`, `pinIssue`, `unpinIssue`, `followTree`, `unfollowTree`, `visitIssue`, `clearReminder`, `addToMyDay`, `removeFromMyDay` (devuelven `true`), `setReminder`, `removeAttachment` (subir: por REST), `duplicateIssue`, `voteIssue` |
| Comentarios | `addComment(replyTo, poll)`, `votePoll`, `closePoll`, `editComment`, `deleteComment`, `reactToComment`, `markDecision(commentId, on)`, `resolveThread(commentId, resolved, conclusion)`, `typing(issueId, threadId)`; consulta `decisions(projectId, search)` | | Comentarios | `addComment(replyTo, poll)`, `votePoll`, `closePoll`, `editComment`, `deleteComment`, `reactToComment`, `markDecision(commentId, on)`, `resolveThread(commentId, resolved, conclusion)`, `turnCommentIntoIssue(commentId, title, type, asSubtask)`, `typing(issueId, threadId)`; consulta `decisions(projectId, search)` |
| Webhooks | `createWebhook` (devuelve el secreto), `updateWebhook`, `deleteWebhook`, `testWebhook` | | Webhooks | `createWebhook` (devuelve el secreto), `updateWebhook`, `deleteWebhook`, `testWebhook` |
| Git | `addGitRepository` (devuelve su secreto), `rotateGitRepositorySecret`, `removeGitRepository` | | Git | `addGitRepository` (devuelve su secreto), `rotateGitRepositorySecret`, `removeGitRepository` |
| Sprints | `createSprint`, `updateSprint`, `startSprint`, `closeSprint(carryOverToSprintId)`, `deleteSprint`, `setIssueSprint` | | Sprints | `createSprint`, `updateSprint`, `startSprint`, `closeSprint(carryOverToSprintId)`, `deleteSprint`, `setIssueSprint` |
@@ -786,7 +794,7 @@ Proyectos y tickets se pueden indicar por **id o por clave** (`WEB`, `WEB-12`).
| Usuarios | `GET /api/users/me`, `GET /api/users?search=`, `GET /api/users/{id}` | | Usuarios | `GET /api/users/me`, `GET /api/users?search=`, `GET /api/users/{id}` |
| Proyectos | `GET/POST /api/projects`, `GET/PATCH/DELETE /api/projects/{project}` (`DELETE …?confirm=CLAVE`), `POST …/archive`, `POST …/unarchive`, `PUT …/settings`, `…/board`, `…/epics`, `…/stats`, `…/analytics?days=`, `…/insights`, `…/activity`, `…/members` (POST, PATCH, DELETE) | | Proyectos | `GET/POST /api/projects`, `GET/PATCH/DELETE /api/projects/{project}` (`DELETE …?confirm=CLAVE`), `POST …/archive`, `POST …/unarchive`, `PUT …/settings`, `…/board`, `…/epics`, `…/stats`, `…/analytics?days=`, `…/insights`, `…/activity`, `…/members` (POST, PATCH, DELETE) |
| Tickets | `GET /api/me/home` (portada), `GET /api/me/portfolio` (cartera), `GET /api/me/issues` (mi trabajo; filtros `project`, `priority`, `bugsOnly`, `overdue`), `GET/POST /api/projects/{project}/issues`, `GET/PATCH /api/issues/{issue}`, `PUT …/status`, `PUT …/assignee`, `PUT …/release`, `PUT/DELETE …/watch`, `POST …/reviews`, `POST …/reviews/{id}/answer`, `DELETE …/reviews/{id}`, `PUT/DELETE …/follow-tree`, `PUT/DELETE …/reminder`, `GET /api/me/reminders`, `GET /api/me/day`, `PUT/DELETE /api/me/day/{issue}`, `GET /api/me/pins` y `PUT/DELETE …/pin` (fijados), `PUT/DELETE …/presence`, `PUT …/parent`, `PUT …/rank`, `POST …/checklist`, `PATCH/DELETE …/checklist/{item}`, `POST/DELETE …/links`, `GET/POST …/comments`, `GET …/history`, `POST /api/issues/{issue}/duplicate`, `PUT/DELETE …/vote` | | Tickets | `GET /api/me/home` (portada), `GET /api/me/portfolio` (cartera), `GET /api/me/issues` (mi trabajo; filtros `project`, `priority`, `bugsOnly`, `overdue`), `GET/POST /api/projects/{project}/issues`, `GET/PATCH /api/issues/{issue}`, `PUT …/status`, `PUT …/assignee`, `PUT …/release`, `PUT/DELETE …/watch`, `POST …/reviews`, `POST …/reviews/{id}/answer`, `DELETE …/reviews/{id}`, `PUT/DELETE …/follow-tree`, `PUT/DELETE …/reminder`, `GET /api/me/reminders`, `GET /api/me/day`, `PUT/DELETE /api/me/day/{issue}`, `GET /api/me/pins` y `PUT/DELETE …/pin` (fijados), `PUT/DELETE …/presence`, `PUT …/parent`, `PUT …/rank`, `POST …/checklist`, `PATCH/DELETE …/checklist/{item}`, `POST/DELETE …/links`, `GET/POST …/comments`, `GET …/history`, `POST /api/issues/{issue}/duplicate`, `PUT/DELETE …/vote` |
| Comentarios | `PATCH/DELETE /api/comments/{commentId}`, `POST …/reactions`, `PUT/DELETE …/decision`, `PUT/DELETE …/resolution`, `POST …/poll/vote`, `POST …/poll/close`; `GET /api/issues/{issue}/decisions`, `GET /api/projects/{project}/decisions`, `GET /api/me/decisions` | | Comentarios | `PATCH/DELETE /api/comments/{commentId}`, `POST …/reactions`, `PUT/DELETE …/decision`, `PUT/DELETE …/resolution`, `POST …/poll/vote`, `POST …/poll/close`, `POST …/issue` (convertir en ticket); `GET /api/issues/{issue}/decisions`, `GET /api/projects/{project}/decisions`, `GET /api/me/decisions` |
| Sprints | `GET/POST /api/projects/{project}/sprints`, `GET/PATCH/DELETE /api/sprints/{sprint}`, `POST …/start`, `POST …/close`, `GET …/progress`, `…/burndown`, `…/issues`, `PUT /api/issues/{issue}/sprint` | | Sprints | `GET/POST /api/projects/{project}/sprints`, `GET/PATCH/DELETE /api/sprints/{sprint}`, `POST …/start`, `POST …/close`, `GET …/progress`, `…/burndown`, `…/issues`, `PUT /api/issues/{issue}/sprint` |
| Vistas | `GET/POST /api/projects/{project}/filters`, `DELETE /api/filters/{id}` | | Vistas | `GET/POST /api/projects/{project}/filters`, `DELETE /api/filters/{id}` |
| Avisos | `GET /api/me/notifications`, `POST /api/me/notifications/read`, `GET/PUT /api/me/notification-settings` | | Avisos | `GET /api/me/notifications`, `POST /api/me/notifications/read`, `GET/PUT /api/me/notification-settings` |

View File

@@ -301,14 +301,14 @@ visualización de la plataforma:
## 4.6 Rutas ## 4.6 Rutas
| Ruta | Página | | Ruta | Página |
| -------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | -------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `/login` | Inicio de sesión (solo sin sesión) | | `/login` | Inicio de sesión (solo sin sesión) |
| `/auth/callback` | Retorno de Pireon (PKCE) | | `/auth/callback` | Retorno de Pireon (PKCE) |
| `/` | Inicio: saludo según la hora con el resumen del día, «Ir a…» (`WEB-12`), primeros pasos, mis proyectos con su actividad (lo primero, para llegar antes), «Mi día» (`ts-my-day`: los tickets que elijo para hoy, tachados al terminar, mis abiertos para añadir y lo que quedó del último día), mis fijados (`ts-pinned`, una franja que se quita con ×; solo si hay), cuatro cifras (`ts-home-kpis`: abiertos míos, esperando QA, terminados por mí y por el equipo esta semana), la semana (`ts-week-agenda`), mis vistas guardadas y dos columnas: mis tickets y lo último en mis proyectos; sprints en curso, esperando QA, que sigo, próximas releases, quién está ahora y «Retomar» | | `/` | Inicio: saludo según la hora con el resumen del día, «Ir a…» (`WEB-12`), primeros pasos, mis proyectos con su actividad (lo primero, para llegar antes), «Mi día» (`ts-my-day`: los tickets que elijo para hoy, tachados al terminar, mis abiertos para añadir y lo que quedó del último día), mis fijados (`ts-pinned`, una franja que se quita con ×; solo si hay), cuatro cifras (`ts-home-kpis`: abiertos míos, esperando QA, terminados por mí y por el equipo esta semana), la semana (`ts-week-agenda`), mis vistas guardadas y dos columnas: mis tickets y lo último en mis proyectos; sprints en curso, esperando QA, que sigo, próximas releases, quién está ahora y «Retomar» |
| `/portfolio` | Cartera (con sesión): una tarjeta por proyecto activo con lo abierto y en riesgo, el sprint en curso (¿llega?), las próximas releases con su previsión y las épicas abiertas; en directo: se vuelve a leer sola cuando cambia un ticket, sprint o release de esos proyectos. Cada proyecto lleva su semáforo de salud (`portfolioHealth`), con las causas al pasar por encima | | `/portfolio` | Cartera (con sesión): una tarjeta por proyecto activo con lo abierto y en riesgo, el sprint en curso (¿llega?), las próximas releases con su previsión y las épicas abiertas; en directo: se vuelve a leer sola cuando cambia un ticket, sprint o release de esos proyectos. Cada proyecto lleva su semáforo de salud (`portfolioHealth`), con las causas al pasar por encima |
| `/explore` | Proyectos públicos (sin sesión) | | `/explore` | Proyectos públicos (sin sesión) |
| `/p/:key/board` | Tablero kanban (`?release=` y `?assignee=` preseleccionan los filtros). Quien puede contribuir cambia prioridad, estimación y persona desde la propia tarjeta (selectores nativos sobre sus distintivos; el título es el enlace). Mover una tarjeta o cambiar su persona ofrece «Deshacer» unos segundos (o Ctrl/⌘ Z): la orden contraria, que el flujo puede rechazar. Con el teclado: Tab entra en las tarjetas, las flechas se mueven entre ellas, Shift+←/→ pasa la tarjeta de columna (mismas reglas que arrastrar), `p`/`e`/`a` abren su prioridad, estimación o persona y Enter la abre | | `/p/:key/board` | Tablero kanban (`?release=` y `?assignee=` preseleccionan los filtros). Quien puede contribuir cambia prioridad, estimación y persona desde la propia tarjeta (selectores nativos sobre sus distintivos; el título es el enlace). Mover una tarjeta o cambiar su persona ofrece «Deshacer» unos segundos (o Ctrl/⌘ Z): la orden contraria, que el flujo puede rechazar. Con el teclado: Tab entra en las tarjetas, las flechas se mueven entre ellas, Shift+←/→ pasa la tarjeta de columna (mismas reglas que arrastrar), `p`/`e`/`a` abren su prioridad, estimación o persona y Enter la abre |
| `/p/:key/issues/:issueKey` | Ticket. Encima del título, quién más lo está viendo o editando ahora (`PresenceFacade`: late cada 10 s; editar es tener abierto el formulario del ticket o de un comentario, o estar escribiendo uno). «Fijar» lo deja a mano en el inicio y en la paleta de búsqueda. Arriba, sus decisiones (comentarios marcados con la bandera por quien puede cambiar el ticket); `?comment=<id>` lleva a un comentario y lo señala. Cambiar el estado o la persona y mandarlo a la papelera (sin confirmación) ofrecen «Deshacer». Cada conversación con respuestas se resuelve («✓ Resolver», con una conclusión opcional que queda como decisión) y se pliega en una línea; la cabecera cuenta las abiertas y terminar el ticket con alguna pregunta antes. Se ve quién está escribiendo en cada conversación («Ana está escribiendo…», `PresenceFacade.typists`), y en las respuestas Enter envía (Shift+Enter, otra línea). Si tiene subtareas, «Seguir todo» avisa de ella y de todo lo que cuelga, también lo que se añada (también desde Épicas). «Recordármelo» pone un aviso solo para mí (dentro de 1 hora, esta tarde, mañana o el lunes a las 9, en una semana o cuando diga), con nota opcional. «☀ Mi día» lo añade a los de hoy. «Pedir revisión» a alguien del equipo: lo ve en «Mi trabajo» («Te piden revisión») y responde «Todo bien» o «Pedir cambios» desde el recuadro Revisiones. Un comentario puede llevar una encuesta («📊 Añadir una encuesta»): se vota pulsando una opción y, al cerrarla, la ganadora queda como decisión. «🎥 Grabar pantalla» (con la voz, si se da permiso al micrófono) y «🎙 Grabar audio» graban en el navegador hasta 3 minutos y lo adjuntan al comentario, que puede ir sin texto; los vídeos y audios adjuntos se reproducen ahí mismo | | `/p/:key/issues/:issueKey` | Ticket. Encima del título, quién más lo está viendo o editando ahora (`PresenceFacade`: late cada 10 s; editar es tener abierto el formulario del ticket o de un comentario, o estar escribiendo uno). «Fijar» lo deja a mano en el inicio y en la paleta de búsqueda. Arriba, sus decisiones (comentarios marcados con la bandera por quien puede cambiar el ticket); `?comment=<id>` lleva a un comentario y lo señala. Cambiar el estado o la persona y mandarlo a la papelera (sin confirmación) ofrecen «Deshacer». Cada conversación con respuestas se resuelve («✓ Resolver», con una conclusión opcional que queda como decisión) y se pliega en una línea; la cabecera cuenta las abiertas y terminar el ticket con alguna pregunta antes. Se ve quién está escribiendo en cada conversación («Ana está escribiendo…», `PresenceFacade.typists`), y en las respuestas Enter envía (Shift+Enter, otra línea). Si tiene subtareas, «Seguir todo» avisa de ella y de todo lo que cuelga, también lo que se añada (también desde Épicas). «Recordármelo» pone un aviso solo para mí (dentro de 1 hora, esta tarde, mañana o el lunes a las 9, en una semana o cuando diga), con nota opcional. «☀ Mi día» lo añade a los de hoy. «Pedir revisión» a alguien del equipo: lo ve en «Mi trabajo» («Te piden revisión») y responde «Todo bien» o «Pedir cambios» desde el recuadro Revisiones. Un comentario puede llevar una encuesta («📊 Añadir una encuesta»): se vota pulsando una opción y, al cerrarla, la ganadora queda como decisión. «🎥 Grabar pantalla» (con la voz, si se da permiso al micrófono) y «🎙 Grabar audio» graban en el navegador hasta 3 minutos y lo adjuntan al comentario, que puede ir sin texto; los vídeos y audios adjuntos se reproducen ahí mismo. Al abrirlo, lo que otros han hecho desde tu última visita: un aviso arriba («Desde tu última visita, hace 2 días: 3 comentarios y 1 cambio de Ana y Bob», con «Ver lo nuevo»), los comentarios nuevos marcados («Nuevo», también en una conversación plegada) y los cambios del historial resaltados. Cada comentario se puede «Convertir en ticket» (subtarea de este o enlazado, con el título sacado de su primera línea): el comentario enlaza al ticket nuevo («→ Convertido en WEB-45») |
| `/p/:key/releases` | Releases. «Página pública» (quien gestiona): un enlace secreto con las notas para clientes, que se copia, renueva o retira | | `/p/:key/releases` | Releases. «Página pública» (quien gestiona): un enlace secreto con las notas para clientes, que se copia, renueva o retira |
| `/p/:key/report/:kind/:id` | Informe para imprimir de un sprint (`sprint`) o una release (`release`): datos, totales, notas y tickets por etapa. «Imprimir o guardar en PDF» abre el diálogo del navegador; al imprimir se quitan la cabecera, las pestañas y los fondos (`styles.scss`) | | `/p/:key/report/:kind/:id` | Informe para imprimir de un sprint (`sprint`) o una release (`release`): datos, totales, notas y tickets por etapa. «Imprimir o guardar en PDF» abre el diálogo del navegador; al imprimir se quitan la cabecera, las pestañas y los fondos (`styles.scss`) |
| `/p/:key/roadmap` | Hoja de ruta: épicas en el tiempo, con sprints y releases; flechas «bloquea» / «depende de» entre épicas y aviso si una empieza antes de que acabe la que la bloquea. Los bloqueos con tickets de otros proyectos (en los dos sentidos, `externalDependencies`) salen en «De otros proyectos» con barra discontinua, sus flechas y el mismo aviso si las fechas no encajan; los que no tienen fechas o no se pueden leer se nombran debajo | | `/p/:key/roadmap` | Hoja de ruta: épicas en el tiempo, con sprints y releases; flechas «bloquea» / «depende de» entre épicas y aviso si una empieza antes de que acabe la que la bloquea. Los bloqueos con tickets de otros proyectos (en los dos sentidos, `externalDependencies`) salen en «De otros proyectos» con barra discontinua, sus flechas y el mismo aviso si las fechas no encajan; los que no tienen fechas o no se pueden leer se nombran debajo |

View File

@@ -74,6 +74,7 @@ flowchart LR
| | `answer_review` | Responder una revisión: todo bien o cambios | | | `answer_review` | Responder una revisión: todo bien o cambios |
| | `vote_poll` | Votar en la encuesta de un comentario (o retirar el voto) | | | `vote_poll` | Votar en la encuesta de un comentario (o retirar el voto) |
| | `close_poll` | Cerrar una encuesta; la ganadora queda como decisión | | | `close_poll` | Cerrar una encuesta; la ganadora queda como decisión |
| | `turn_comment_into_issue` | Convertir un comentario en ticket: subtarea del suyo o enlazado; su texto es la descripción |
| | `search_decisions` | Qué se decidió: decisiones por su texto, de un proyecto o de todos los míos | | | `search_decisions` | Qué se decidió: decisiones por su texto, de un proyecto o de todos los míos |
| | `add_checklist_item` / `update_checklist_item` / `remove_checklist_item` | La lista de comprobación: añadir, marcar o reescribir, quitar | | | `add_checklist_item` / `update_checklist_item` / `remove_checklist_item` | La lista de comprobación: añadir, marcar o reescribir, quitar |
| Organización | `list_epics` | Épicas con el progreso de lo que cuelga de cada una | | Organización | `list_epics` | Épicas con el progreso de lo que cuelga de cada una |

View File

@@ -43,6 +43,9 @@ export * from './lib/alerts.service';
export * from './lib/follows/tree-follows'; export * from './lib/follows/tree-follows';
export * from './lib/ports/tree-follows.repository'; export * from './lib/ports/tree-follows.repository';
export * from './lib/tree-follows.service'; export * from './lib/tree-follows.service';
export * from './lib/visits/issue-visits';
export * from './lib/ports/issue-visits.repository';
export * from './lib/issue-visits.service';
export * from './lib/reminders/issue-reminders'; export * from './lib/reminders/issue-reminders';
export * from './lib/ports/issue-reminders.repository'; export * from './lib/ports/issue-reminders.repository';
export * from './lib/issue-reminders.service'; export * from './lib/issue-reminders.service';
@@ -51,6 +54,7 @@ export * from './lib/ports/my-days.repository';
export * from './lib/my-day.service'; export * from './lib/my-day.service';
export * from './lib/commands/reviews'; export * from './lib/commands/reviews';
export * from './lib/commands/polls'; export * from './lib/commands/polls';
export * from './lib/commands/turn-comment-into-issue';
export * from './lib/sharing/release-notes-shares'; export * from './lib/sharing/release-notes-shares';
export * from './lib/ports/release-note-shares.repository'; export * from './lib/ports/release-note-shares.repository';
export * from './lib/tracker-application.module'; export * from './lib/tracker-application.module';

View File

@@ -3,6 +3,7 @@ import { MarkDecisionCommandHandler } from './mark-decision.command-handler';
import { ResolveThreadCommandHandler } from './resolve-thread.command-handler'; import { ResolveThreadCommandHandler } from './resolve-thread.command-handler';
import { REVIEW_HANDLERS } from './reviews'; import { REVIEW_HANDLERS } from './reviews';
import { POLL_HANDLERS } from './polls'; import { POLL_HANDLERS } from './polls';
import { TURN_INTO_ISSUE_HANDLERS } from './turn-comment-into-issue';
import { VoteIssueCommandHandler } from './vote-issue.command-handler'; import { VoteIssueCommandHandler } from './vote-issue.command-handler';
import { CreateProjectCommandHandler } from './create-project.command-handler'; import { CreateProjectCommandHandler } from './create-project.command-handler';
import { UpdateProjectCommandHandler } from './update-project.command-handler'; import { UpdateProjectCommandHandler } from './update-project.command-handler';
@@ -54,6 +55,7 @@ export const COMMAND_HANDLERS = [
ResolveThreadCommandHandler, ResolveThreadCommandHandler,
...REVIEW_HANDLERS, ...REVIEW_HANDLERS,
...POLL_HANDLERS, ...POLL_HANDLERS,
...TURN_INTO_ISSUE_HANDLERS,
CreateProjectCommandHandler, CreateProjectCommandHandler,
UpdateProjectCommandHandler, UpdateProjectCommandHandler,
UpdateProjectSettingsCommandHandler, UpdateProjectSettingsCommandHandler,

View File

@@ -15,6 +15,7 @@ import {
import { import {
Comment, Comment,
Issue, Issue,
IssueLinkType,
IssueStatus, IssueStatus,
Project, Project,
IssuePriority, IssuePriority,
@@ -81,6 +82,7 @@ import { ReactToCommentCommand } from './react-to-comment.command';
import { MarkDecisionCommand } from './mark-decision.command'; import { MarkDecisionCommand } from './mark-decision.command';
import { ResolveThreadCommand } from './resolve-thread.command'; import { ResolveThreadCommand } from './resolve-thread.command';
import { ClosePollCommand, VotePollCommand } from './polls'; import { ClosePollCommand, VotePollCommand } from './polls';
import { TurnCommentIntoIssueCommand } from './turn-comment-into-issue';
import { import {
AnswerReviewCommand, AnswerReviewCommand,
CancelReviewCommand, CancelReviewCommand,
@@ -951,6 +953,65 @@ describe('tracker commands (event sourced)', () => {
); );
}); });
it('makes a ticket of a comment, as a subtask or linked, and marks the comment', async () => {
const { run, rehydrator } = await setup();
const projectId = await projectWithTeam(run);
const issue = await run(
new CreateIssueCommand('dev', projectId, IssueType.BUG, 'Pago', {}),
);
const comment = await run(
new AddCommentCommand('qa', issue.id, 'También falla en **Android**'),
);
// Viewers comment and react; making tickets is for the team.
await expect(
run(
new TurnCommentIntoIssueCommand(
'pm',
comment.id,
'Android',
IssueType.BUG,
false,
),
),
).rejects.toThrow(ForbiddenError);
const linked = await run(
new TurnCommentIntoIssueCommand(
'dev',
comment.id,
'Falla en Android',
IssueType.BUG,
false,
),
);
const sub = await run(
new TurnCommentIntoIssueCommand(
'dev',
comment.id,
'Probar en Android',
IssueType.TASK,
true,
),
);
const fromLink = await rehydrator.rehydrate(linked.id, Issue);
expect(fromLink.title).toBe('Falla en Android');
expect(fromLink.description).toBe(
'También falla en **Android**\n\n---\n_Sale de un comentario de user qa en TS-1._',
);
expect(fromLink.links).toEqual([
expect.objectContaining({
type: IssueLinkType.RELATES_TO,
targetIssueId: issue.id,
}),
]);
expect((await rehydrator.rehydrate(sub.id, Issue)).parentId).toBe(issue.id);
expect((await rehydrator.rehydrate(comment.id, Comment)).spawned).toEqual([
{ id: linked.id, key: 'TS-2' },
{ id: sub.id, key: 'TS-3' },
]);
});
it('takes votes in a comment poll and keeps the winner as a decision', async () => { it('takes votes in a comment poll and keeps the winner as a decision', async () => {
const { run, rehydrator, store } = await setup(); const { run, rehydrator, store } = await setup();
const projectId = await projectWithTeam(run); const projectId = await projectWithTeam(run);

View File

@@ -0,0 +1,94 @@
import {
Command,
CommandBus,
CommandHandler,
ICommandHandler,
} from '@nestjs/cqrs';
import { BusinessRuleError } from '@task-stream/api/shared/domain';
import { IssueLinkType } from '@task-stream/api/tracker/domain';
import { UserDirectory } from '../ports/user-directory';
import { CommandResult } from './command-result';
import { CreateIssueCommand } from './create-issue.command';
import { LinkIssuesCommand } from './link-issues.command';
import { WriteAccess } from './write-access';
/*
* «Convertir en ticket»: a comment that turns out to be work of its own
* («también falla en Android») becomes a ticket, as a subtask of the one it
* was said on or linked to it. Its text is the new description, and the
* comment shows where it went («→ WEB-45»).
*/
export class TurnCommentIntoIssueCommand extends Command<CommandResult> {
constructor(
public readonly actorId: string,
public readonly commentId: string,
public readonly title: string,
/** Ticket type id of the project's settings. */
public readonly type: string,
/** Hang it from the ticket of the comment; otherwise, link them. */
public readonly asSubtask: boolean,
) {
super();
}
}
/** Answers the new ticket (id, key, version). */
@CommandHandler(TurnCommentIntoIssueCommand)
export class TurnCommentIntoIssueCommandHandler
implements ICommandHandler<TurnCommentIntoIssueCommand>
{
constructor(
private readonly access: WriteAccess,
private readonly commandBus: CommandBus,
private readonly users: UserDirectory,
) {}
async execute(command: TurnCommentIntoIssueCommand): Promise<CommandResult> {
const comment = await this.access.comment(command.commentId);
const source = await this.access.issue(comment.issueId);
const project = await this.access.project(comment.projectId);
this.access.assertSees(project, source, command.actorId);
// Creating and linking tickets is for the team: those commands check it.
project.assertCanContribute(command.actorId);
if (comment.deleted) throw new BusinessRuleError('Comment was deleted');
const author = (await this.users.refs([comment.authorId])).of(
comment.authorId,
);
const created = await this.commandBus.execute(
new CreateIssueCommand(
command.actorId,
project.id,
command.type,
command.title,
{
description: `${comment.body}\n\n---\n_Sale de un comentario de ${author.name} en ${source.key}._`,
},
null,
null,
command.asSubtask ? source.id : null,
null,
// The comment is the content: no template on top of it.
false,
),
);
if (!command.asSubtask)
await this.commandBus.execute(
new LinkIssuesCommand(
command.actorId,
created.id,
IssueLinkType.RELATES_TO,
source.id,
),
);
comment.turnedInto(command.actorId, {
id: created.id,
key: created.key ?? '',
});
await comment.commitAndWait();
return created;
}
}
export const TURN_INTO_ISSUE_HANDLERS = [TurnCommentIntoIssueCommandHandler];

View File

@@ -11,6 +11,7 @@ import { DeleteCommentCommand } from './commands/delete-comment.command';
import { EditCommentCommand } from './commands/edit-comment.command'; import { EditCommentCommand } from './commands/edit-comment.command';
import { ReactToCommentCommand } from './commands/react-to-comment.command'; import { ReactToCommentCommand } from './commands/react-to-comment.command';
import { MarkDecisionCommand } from './commands/mark-decision.command'; import { MarkDecisionCommand } from './commands/mark-decision.command';
import { TurnCommentIntoIssueCommand } from './commands/turn-comment-into-issue';
import { ResolveThreadCommand } from './commands/resolve-thread.command'; import { ResolveThreadCommand } from './commands/resolve-thread.command';
import { ClosePollCommand, VotePollCommand } from './commands/polls'; import { ClosePollCommand, VotePollCommand } from './commands/polls';
import { Page } from './ports/find-issues.repository'; import { Page } from './ports/find-issues.repository';
@@ -109,6 +110,25 @@ export class CommentsService {
); );
} }
/** Makes a ticket of a comment: a subtask of its ticket, or linked to it. */
turnIntoIssue(
actorId: string,
commentId: string,
title: string,
type: string,
asSubtask: boolean,
): Promise<CommandResult> {
return this.commands.execute(
new TurnCommentIntoIssueCommand(
actorId,
commentId,
title,
type,
asSubtask,
),
);
}
/** A ticket's decisions, oldest first. */ /** A ticket's decisions, oldest first. */
decisions( decisions(
viewerId: string | null, viewerId: string | null,

View File

@@ -43,6 +43,7 @@ export class CommentAddedEventHandler
resolved: false, resolved: false,
resolvedBy: null, resolvedBy: null,
resolvedAt: null, resolvedAt: null,
spawned: [],
createdAt: comment.createdAt, createdAt: comment.createdAt,
editedAt: null, editedAt: null,
version: versionOf(event), version: versionOf(event),

View File

@@ -0,0 +1,23 @@
import { EventsHandler, IEventHandler } from '@nestjs/cqrs';
import { CommentTurnedIntoIssueEvent } from '@task-stream/api/tracker/domain';
import { UpsertMaterializedCommentRepository } from '../ports/upsert-materialized-comment.repository';
import { ReadModelNotifier, versionOf } from './read-model-notifier';
@EventsHandler(CommentTurnedIntoIssueEvent)
export class CommentTurnedIntoIssueEventHandler
implements IEventHandler<CommentTurnedIntoIssueEvent>
{
constructor(
private readonly upsertMaterializedCommentRepository: UpsertMaterializedCommentRepository,
private readonly notifier: ReadModelNotifier,
) {}
async handle(event: CommentTurnedIntoIssueEvent) {
await this.upsertMaterializedCommentRepository.upsert({
id: event.aggregateId,
spawned: event.spawned,
version: versionOf(event),
});
await this.notifier.comment(event.aggregateId, event.issueId, event);
}
}

View File

@@ -5,6 +5,7 @@ import { CommentEditedEventHandler } from './comment-edited.event-handler';
import { CommentReactedEventHandler } from './comment-reacted.event-handler'; import { CommentReactedEventHandler } from './comment-reacted.event-handler';
import { CommentDecisionMarkedEventHandler } from './comment-decision-marked.event-handler'; import { CommentDecisionMarkedEventHandler } from './comment-decision-marked.event-handler';
import { CommentThreadResolvedEventHandler } from './comment-thread-resolved.event-handler'; import { CommentThreadResolvedEventHandler } from './comment-thread-resolved.event-handler';
import { CommentTurnedIntoIssueEventHandler } from './comment-turned-into-issue.event-handler';
import { IssueReviewsEventHandler } from './issue-reviews.event-handler'; import { IssueReviewsEventHandler } from './issue-reviews.event-handler';
import { CommentPollEventHandler } from './comment-poll.event-handler'; import { CommentPollEventHandler } from './comment-poll.event-handler';
import { IssueVotedEventHandler } from './issue-voted.event-handler'; import { IssueVotedEventHandler } from './issue-voted.event-handler';
@@ -56,6 +57,7 @@ export const EVENT_HANDLERS = [
CommentReactedEventHandler, CommentReactedEventHandler,
CommentDecisionMarkedEventHandler, CommentDecisionMarkedEventHandler,
CommentThreadResolvedEventHandler, CommentThreadResolvedEventHandler,
CommentTurnedIntoIssueEventHandler,
IssueReviewsEventHandler, IssueReviewsEventHandler,
CommentPollEventHandler, CommentPollEventHandler,
IssueVotedEventHandler, IssueVotedEventHandler,

View File

@@ -0,0 +1,14 @@
import { CommandRunner } from '@task-stream/api/shared/application';
import { Injectable } from '@nestjs/common';
import { VisitIssueCommand } from './visits/issue-visits';
/** When I last opened a ticket, to tell what is new since. */
@Injectable()
export class IssueVisitsService {
constructor(private readonly commands: CommandRunner) {}
/** Notes that I opened it now; returns my visit before (null: never). */
visit(userId: string, issueId: string): Promise<string | null> {
return this.commands.execute(new VisitIssueCommand(userId, issueId));
}
}

View File

@@ -0,0 +1,11 @@
/** When someone last opened a ticket: personal, no history. */
export interface IssueVisit {
userId: string;
issueId: string;
seenAt: string;
}
export abstract class IssueVisitsRepository {
/** Notes this visit; returns when the one before it was (null: never). */
abstract visit(visit: IssueVisit): Promise<string | null>;
}

View File

@@ -38,6 +38,8 @@ import { MY_VIEWS } from './saved-filters/my-views';
import { PINS } from './saved-filters/pins'; import { PINS } from './saved-filters/pins';
import { ALERT_HANDLERS } from './alerts/alerts'; import { ALERT_HANDLERS } from './alerts/alerts';
import { TREE_FOLLOWS } from './follows/tree-follows'; import { TREE_FOLLOWS } from './follows/tree-follows';
import { ISSUE_VISITS } from './visits/issue-visits';
import { IssueVisitsService } from './issue-visits.service';
import { ISSUE_REMINDERS } from './reminders/issue-reminders'; import { ISSUE_REMINDERS } from './reminders/issue-reminders';
import { MY_DAY } from './my-day/my-day'; import { MY_DAY } from './my-day/my-day';
import { RELEASE_NOTES_SHARES } from './sharing/release-notes-shares'; import { RELEASE_NOTES_SHARES } from './sharing/release-notes-shares';
@@ -92,6 +94,7 @@ const SERVICES = [
PinsService, PinsService,
AlertsService, AlertsService,
TreeFollowsService, TreeFollowsService,
IssueVisitsService,
IssueRemindersService, IssueRemindersService,
MyDayService, MyDayService,
SprintsService, SprintsService,
@@ -127,6 +130,7 @@ const SERVICES = [
...PINS, ...PINS,
...ALERT_HANDLERS, ...ALERT_HANDLERS,
...TREE_FOLLOWS, ...TREE_FOLLOWS,
...ISSUE_VISITS,
...ISSUE_REMINDERS, ...ISSUE_REMINDERS,
...MY_DAY, ...MY_DAY,
...RELEASE_NOTES_SHARES, ...RELEASE_NOTES_SHARES,

View File

@@ -0,0 +1,51 @@
import {
Command,
CommandHandler,
ICommandHandler,
QueryBus,
} from '@nestjs/cqrs';
import { NotFoundError } from '@task-stream/api/shared/domain';
import { IssueReadModel } from '@task-stream/api/tracker/domain';
import { IssueVisitsRepository } from '../ports/issue-visits.repository';
import { GetIssuesByIdsQuery } from '../queries/get-issues-by-ids.query';
/*
* «Lo nuevo desde tu última visita»: opening a ticket notes the moment, and
* says when the visit before was, so the client can tell what others did
* meanwhile. Personal, no history (like pinned tickets).
*/
export class VisitIssueCommand extends Command<string | null> {
constructor(
public readonly userId: string,
public readonly issueId: string,
) {
super();
}
}
@CommandHandler(VisitIssueCommand)
export class VisitIssueCommandHandler
implements ICommandHandler<VisitIssueCommand>
{
constructor(
private readonly visits: IssueVisitsRepository,
private readonly queryBus: QueryBus,
) {}
async execute(command: VisitIssueCommand): Promise<string | null> {
const { userId, issueId } = command;
const [issue]: IssueReadModel[] = await this.queryBus.execute(
new GetIssuesByIdsQuery(userId, [issueId]),
);
// A ticket I cannot read does not exist, as far as I know.
if (!issue) throw new NotFoundError('Issue', issueId);
return this.visits.visit({
userId,
issueId,
seenAt: new Date().toISOString(),
});
}
}
export const ISSUE_VISITS = [VisitIssueCommandHandler];

View File

@@ -7,6 +7,7 @@ import {
import { CommentAddedEvent } from '../events/comment-added.event'; import { CommentAddedEvent } from '../events/comment-added.event';
import { CommentDecisionMarkedEvent } from '../events/comment-decision-marked.event'; import { CommentDecisionMarkedEvent } from '../events/comment-decision-marked.event';
import { CommentThreadResolvedEvent } from '../events/comment-thread-resolved.event'; import { CommentThreadResolvedEvent } from '../events/comment-thread-resolved.event';
import { CommentTurnedIntoIssueEvent } from '../events/comment-turned-into-issue.event';
import { import {
CommentPollClosedEvent, CommentPollClosedEvent,
CommentPollVotedEvent, CommentPollVotedEvent,
@@ -82,6 +83,8 @@ export class Comment extends VersionedAggregateRoot implements CommentProps {
public pollVotes: Record<string, number> = {}; public pollVotes: Record<string, number> = {};
public pollClosed = false; public pollClosed = false;
public pollWinner: number | null = null; public pollWinner: number | null = null;
/** Tickets made from it, oldest first. */
public spawned: { id: string; key: string }[] = [];
public deleted = false; public deleted = false;
public createdAt!: string; public createdAt!: string;
public editedAt: string | null = null; public editedAt: string | null = null;
@@ -277,10 +280,32 @@ export class Comment extends VersionedAggregateRoot implements CommentProps {
this.resolved = event.resolved; this.resolved = event.resolved;
} }
onCommentTurnedIntoIssueEvent(event: CommentTurnedIntoIssueEvent): void {
this.spawned = event.spawned;
}
onCommentDeletedEvent(): void { onCommentDeletedEvent(): void {
this.deleted = true; this.deleted = true;
} }
/**
* Notes a ticket made from it (its text became the ticket's description).
* Who may create it is the caller's check.
*/
turnedInto(actorId: string, issue: { id: string; key: string }): void {
this.assertAlive();
if (this.spawned.some((s) => s.id === issue.id)) return;
this.apply(
new CommentTurnedIntoIssueEvent(
actorId,
this.id,
this.projectId,
this.issueId,
[...this.spawned, issue],
),
);
}
private assertAlive(): void { private assertAlive(): void {
if (this.deleted) throw new BusinessRuleError('Comment was deleted'); if (this.deleted) throw new BusinessRuleError('Comment was deleted');
} }

View File

@@ -0,0 +1,17 @@
import { AutowiredEvent } from '@task-stream/api/shared/domain';
import { TrackerEvent } from './tracker.event';
/** A ticket of its own was made from a comment («→ WEB-45» on it). */
@AutowiredEvent
export class CommentTurnedIntoIssueEvent extends TrackerEvent {
constructor(
actorId: string,
commentId: string,
projectId: string,
readonly issueId: string,
/** Every ticket made from it so far, this one last. */
readonly spawned: { id: string; key: string }[],
) {
super(actorId, commentId, projectId);
}
}

View File

@@ -17,6 +17,7 @@ export * from './comment-edited.event';
export * from './comment-reacted.event'; export * from './comment-reacted.event';
export * from './comment-decision-marked.event'; export * from './comment-decision-marked.event';
export * from './comment-thread-resolved.event'; export * from './comment-thread-resolved.event';
export * from './comment-turned-into-issue.event';
export * from './issue-review.events'; export * from './issue-review.events';
export * from './comment-poll.events'; export * from './comment-poll.events';
export * from './comment-deleted.event'; export * from './comment-deleted.event';

View File

@@ -41,6 +41,8 @@ export class CommentReadModel {
/** Who settled it and when (null while open). */ /** Who settled it and when (null while open). */
resolvedBy!: UserRefReadModel | null; resolvedBy!: UserRefReadModel | null;
resolvedAt!: string | null; resolvedAt!: string | null;
/** Tickets made from it («Convertir en ticket»), oldest first. */
spawned!: { id: string; key: string }[];
createdAt!: string; createdAt!: string;
editedAt!: string | null; editedAt!: string | null;
version!: number; version!: number;

View File

@@ -58,6 +58,7 @@ const commentFromDoc = (doc: CommentDoc): CommentReadModel => ({
resolved: doc.resolved ?? false, resolved: doc.resolved ?? false,
resolvedBy: doc.resolvedBy ?? null, resolvedBy: doc.resolvedBy ?? null,
resolvedAt: doc.resolvedAt ?? null, resolvedAt: doc.resolvedAt ?? null,
spawned: doc.spawned ?? [],
}); });
const escapeRegex = (text: string) => const escapeRegex = (text: string) =>

View File

@@ -0,0 +1,30 @@
import { Injectable } from '@nestjs/common';
import { InjectModel } from '@nestjs/mongoose';
import {
IssueVisit,
IssueVisitsRepository,
} from '@task-stream/api/tracker/application';
import { Model } from 'mongoose';
import { ReadModels } from './read-model.schemas';
@Injectable()
export class MongoIssueVisitsRepository extends IssueVisitsRepository {
constructor(
@InjectModel(ReadModels.IssueVisit)
private readonly visits: Model<IssueVisit>,
) {
super();
}
async visit(visit: IssueVisit): Promise<string | null> {
// One round trip: the document as it was before this visit.
const before = await this.visits
.findOneAndUpdate(
{ userId: visit.userId, issueId: visit.issueId },
{ $set: { seenAt: visit.seenAt } },
{ upsert: true, new: false },
)
.lean<IssueVisit>();
return before?.seenAt ?? null;
}
}

View File

@@ -110,6 +110,7 @@ export const ReadModels = {
AlertIntegration: 'AlertIntegration', AlertIntegration: 'AlertIntegration',
AlertTrace: 'AlertTrace', AlertTrace: 'AlertTrace',
TreeFollow: 'TreeFollow', TreeFollow: 'TreeFollow',
IssueVisit: 'IssueVisit',
IssueReminder: 'IssueReminder', IssueReminder: 'IssueReminder',
MyDay: 'MyDay', MyDay: 'MyDay',
ReleaseNotesShare: 'ReleaseNotesShare', ReleaseNotesShare: 'ReleaseNotesShare',
@@ -373,6 +374,16 @@ export const TreeFollowSchema =
SchemaFactory.createForClass(TreeFollowDocument); SchemaFactory.createForClass(TreeFollowDocument);
TreeFollowSchema.index({ userId: 1, issueId: 1 }, { unique: true }); TreeFollowSchema.index({ userId: 1, issueId: 1 }, { unique: true });
@Schema({ ...LOOSE, collection: 'issue_visits' })
class IssueVisitDocument {
@Prop({ type: String }) userId!: string;
@Prop({ type: String }) issueId!: string;
@Prop({ type: String }) seenAt!: string;
}
export const IssueVisitSchema =
SchemaFactory.createForClass(IssueVisitDocument);
IssueVisitSchema.index({ userId: 1, issueId: 1 }, { unique: true });
@Schema({ ...LOOSE, collection: 'issue_reminders' }) @Schema({ ...LOOSE, collection: 'issue_reminders' })
class IssueReminderDocument { class IssueReminderDocument {
@Prop({ type: String, required: true, unique: true }) id!: string; @Prop({ type: String, required: true, unique: true }) id!: string;
@@ -511,6 +522,7 @@ export const READ_MODEL_SCHEMAS = [
{ name: ReadModels.AlertIntegration, schema: AlertIntegrationSchema }, { name: ReadModels.AlertIntegration, schema: AlertIntegrationSchema },
{ name: ReadModels.AlertTrace, schema: AlertTraceSchema }, { name: ReadModels.AlertTrace, schema: AlertTraceSchema },
{ name: ReadModels.TreeFollow, schema: TreeFollowSchema }, { name: ReadModels.TreeFollow, schema: TreeFollowSchema },
{ name: ReadModels.IssueVisit, schema: IssueVisitSchema },
{ name: ReadModels.IssueReminder, schema: IssueReminderSchema }, { name: ReadModels.IssueReminder, schema: IssueReminderSchema },
{ name: ReadModels.MyDay, schema: MyDaySchema }, { name: ReadModels.MyDay, schema: MyDaySchema },
{ name: ReadModels.ReleaseNotesShare, schema: ReleaseNotesShareSchema }, { name: ReadModels.ReleaseNotesShare, schema: ReleaseNotesShareSchema },

View File

@@ -16,6 +16,7 @@ import {
PinsRepository, PinsRepository,
AlertIntegrationsRepository, AlertIntegrationsRepository,
TreeFollowsRepository, TreeFollowsRepository,
IssueVisitsRepository,
IssueRemindersRepository, IssueRemindersRepository,
MyDaysRepository, MyDaysRepository,
ReleaseNoteSharesRepository, ReleaseNoteSharesRepository,
@@ -87,6 +88,7 @@ import { MongoMyViewsRepository } from './mongo/my-views.repository';
import { MongoPinsRepository } from './mongo/pins.repository'; import { MongoPinsRepository } from './mongo/pins.repository';
import { MongoAlertIntegrationsRepository } from './mongo/alert-integrations.repository'; import { MongoAlertIntegrationsRepository } from './mongo/alert-integrations.repository';
import { MongoTreeFollowsRepository } from './mongo/tree-follows.repository'; import { MongoTreeFollowsRepository } from './mongo/tree-follows.repository';
import { MongoIssueVisitsRepository } from './mongo/issue-visits.repository';
import { MongoIssueRemindersRepository } from './mongo/issue-reminders.repository'; import { MongoIssueRemindersRepository } from './mongo/issue-reminders.repository';
import { MongoMyDaysRepository } from './mongo/my-days.repository'; import { MongoMyDaysRepository } from './mongo/my-days.repository';
import { MongoReleaseNoteSharesRepository } from './mongo/release-note-shares.repository'; import { MongoReleaseNoteSharesRepository } from './mongo/release-note-shares.repository';
@@ -172,6 +174,7 @@ const PORTS = [
useClass: MongoAlertIntegrationsRepository, useClass: MongoAlertIntegrationsRepository,
}, },
{ provide: TreeFollowsRepository, useClass: MongoTreeFollowsRepository }, { provide: TreeFollowsRepository, useClass: MongoTreeFollowsRepository },
{ provide: IssueVisitsRepository, useClass: MongoIssueVisitsRepository },
{ {
provide: IssueRemindersRepository, provide: IssueRemindersRepository,
useClass: MongoIssueRemindersRepository, useClass: MongoIssueRemindersRepository,

View File

@@ -113,6 +113,27 @@ export class CommentResolver {
); );
} }
@Mutation(() => CommandResultGql, {
description:
'Make a ticket of a comment: its text becomes the description, as a subtask of its ticket or linked to it (RELATES_TO). Answers the new ticket. Whoever can change tickets',
})
turnCommentIntoIssue(
@CurrentUser() me: User,
@Args('commentId', { type: () => ID }) commentId: string,
@Args('title') title: string,
@Args('type', { description: "One of the project's ticket type ids" })
type: string,
@Args('asSubtask', { defaultValue: false }) asSubtask: boolean,
) {
return this.comments.turnIntoIssue(
me.id,
commentId,
title,
type,
asSubtask,
);
}
@OptionalAuth() @OptionalAuth()
@Query(() => [DecisionGql], { @Query(() => [DecisionGql], {
description: description:

View File

@@ -20,6 +20,7 @@ import {
PinsService, PinsService,
TreeFollowsService, TreeFollowsService,
IssueRemindersService, IssueRemindersService,
IssueVisitsService,
MyDayService, MyDayService,
PresenceService, PresenceService,
WorkflowsService, WorkflowsService,
@@ -73,6 +74,7 @@ export class IssueResolver {
private readonly treeFollows: TreeFollowsService, private readonly treeFollows: TreeFollowsService,
private readonly reminders: IssueRemindersService, private readonly reminders: IssueRemindersService,
private readonly myDayService: MyDayService, private readonly myDayService: MyDayService,
private readonly visits: IssueVisitsService,
) {} ) {}
@Mutation(() => [PresenceGql], { @Mutation(() => [PresenceGql], {
@@ -452,6 +454,18 @@ export class IssueResolver {
return true; return true;
} }
@Mutation(() => String, {
nullable: true,
description:
'I opened this ticket now: answers when I had opened it before (null: never), to show what is new since',
})
visitIssue(
@CurrentUser() me: User,
@Args('issueId', { type: () => ID }) issueId: string,
): Promise<string | null> {
return this.visits.visit(me.id, issueId);
}
@Query(() => MyDayGql, { @Query(() => MyDayGql, {
description: description:
'«Mi día»: the tickets I picked for today, and what was left on my last day', '«Mi día»: the tickets I picked for today, and what was left on my last day',

View File

@@ -572,6 +572,12 @@ export class CommentPollGql {
winner!: number | null; winner!: number | null;
} }
@ObjectType('CommentSpawn', { description: 'A ticket made from a comment' })
export class CommentSpawnGql {
@Field(() => ID) id!: string;
@Field() key!: string;
}
@ObjectType('Comment') @ObjectType('Comment')
export class CommentGql { export class CommentGql {
@Field(() => ID) id!: string; @Field(() => ID) id!: string;
@@ -615,6 +621,10 @@ export class CommentGql {
}) })
resolvedBy!: UserRefGql | null; resolvedBy!: UserRefGql | null;
@Field(() => String, { nullable: true }) resolvedAt!: string | null; @Field(() => String, { nullable: true }) resolvedAt!: string | null;
@Field(() => [CommentSpawnGql], {
description: 'Tickets made from it («Convertir en ticket»), oldest first',
})
spawned!: CommentSpawnGql[];
@Field() createdAt!: string; @Field() createdAt!: string;
@Field(() => String, { nullable: true }) editedAt!: string | null; @Field(() => String, { nullable: true }) editedAt!: string | null;
@Field(() => Int) version!: number; @Field(() => Int) version!: number;

View File

@@ -22,6 +22,7 @@ import {
ClosePollDto, ClosePollDto,
ReactToCommentDto, ReactToCommentDto,
ResolveThreadDto, ResolveThreadDto,
TurnCommentIntoIssueDto,
VotePollDto, VotePollDto,
} from './dto/requests.dto'; } from './dto/requests.dto';
import { CommandResultDto } from './dto/responses.dto'; import { CommandResultDto } from './dto/responses.dto';
@@ -117,6 +118,28 @@ export class CommentsController {
return this.comments.closePoll(me.id, commentId, body.decide ?? true); return this.comments.closePoll(me.id, commentId, body.decide ?? true);
} }
@Post(':commentId/issue')
@ApiOperation({
summary: 'Make a ticket of a comment',
description:
'Its text becomes the description, as a subtask of its ticket or linked to it (RELATES_TO); the comment shows where it went. Answers the new ticket. Whoever can change tickets.',
})
@ApiOkResponse({ type: CommandResultDto })
@ApiCommandErrors()
turnIntoIssue(
@CurrentUser() me: User,
@Param('commentId') commentId: string,
@Body() body: TurnCommentIntoIssueDto,
) {
return this.comments.turnIntoIssue(
me.id,
commentId,
body.title,
body.type,
body.asSubtask ?? false,
);
}
@Put(':commentId/resolution') @Put(':commentId/resolution')
@ApiOperation({ @ApiOperation({
summary: 'Settle a conversation (a top-level comment and its replies)', summary: 'Settle a conversation (a top-level comment and its replies)',

View File

@@ -1640,6 +1640,27 @@ export class SetReminderDto {
note?: string; note?: string;
} }
export class TurnCommentIntoIssueDto {
@ApiProperty({ example: 'También falla en Android', maxLength: 200 })
@IsString()
@MinLength(1)
@MaxLength(200)
title!: string;
@ApiProperty({ description: "One of the project's ticket type ids" })
@IsString()
type!: string;
@ApiPropertyOptional({
default: false,
description:
'Hang it from the ticket of the comment; otherwise it is linked to it (RELATES_TO)',
})
@IsOptional()
@IsBoolean()
asSubtask?: boolean;
}
export class ResolveThreadDto { export class ResolveThreadDto {
@ApiPropertyOptional({ @ApiPropertyOptional({
description: description:

View File

@@ -628,6 +628,10 @@ export class CommentPollDto {
winner!: number | null; winner!: number | null;
} }
export class CommentSpawnDto {
@ApiProperty() id!: string;
@ApiProperty({ example: 'WEB-45' }) key!: string;
}
export class CommentDto { export class CommentDto {
@ApiProperty({ format: 'uuid' }) id!: string; @ApiProperty({ format: 'uuid' }) id!: string;
@ApiProperty({ format: 'uuid' }) issueId!: string; @ApiProperty({ format: 'uuid' }) issueId!: string;
@@ -679,6 +683,11 @@ export class CommentDto {
resolvedBy!: UserRefDto | null; resolvedBy!: UserRefDto | null;
@ApiProperty({ type: String, nullable: true, format: 'date-time' }) @ApiProperty({ type: String, nullable: true, format: 'date-time' })
resolvedAt!: string | null; resolvedAt!: string | null;
@ApiProperty({
type: () => [CommentSpawnDto],
description: 'Tickets made from it («Convertir en ticket»), oldest first',
})
spawned!: CommentSpawnDto[];
@ApiProperty({ format: 'date-time' }) createdAt!: string; @ApiProperty({ format: 'date-time' }) createdAt!: string;
@ApiProperty({ type: String, nullable: true, format: 'date-time' }) @ApiProperty({ type: String, nullable: true, format: 'date-time' })
editedAt!: string | null; editedAt!: string | null;
@@ -1447,6 +1456,16 @@ export class IssueReminderDto {
@ApiProperty({ type: String, nullable: true }) note!: string | null; @ApiProperty({ type: String, nullable: true }) note!: string | null;
} }
export class IssueVisitDto {
@ApiProperty({
type: String,
format: 'date-time',
nullable: true,
description: 'My visit before this one (null: first time)',
})
previousVisit!: string | null;
}
export class ReminderOnIssueDto { export class ReminderOnIssueDto {
@ApiProperty({ type: IssueReminderDto }) reminder!: IssueReminderDto; @ApiProperty({ type: IssueReminderDto }) reminder!: IssueReminderDto;
@ApiProperty({ type: () => IssueDto }) issue!: IssueDto; @ApiProperty({ type: () => IssueDto }) issue!: IssueDto;

View File

@@ -35,6 +35,7 @@ import {
PinsService, PinsService,
TreeFollowsService, TreeFollowsService,
IssueRemindersService, IssueRemindersService,
IssueVisitsService,
MyDayService, MyDayService,
PresenceService, PresenceService,
ProjectsService, ProjectsService,
@@ -73,6 +74,7 @@ import {
CommentPageDto, CommentPageDto,
DecisionDto, DecisionDto,
IssueReminderDto, IssueReminderDto,
IssueVisitDto,
MyDayDto, MyDayDto,
ReminderOnIssueDto, ReminderOnIssueDto,
EpicDto, EpicDto,
@@ -112,6 +114,7 @@ export class IssuesController {
private readonly treeFollows: TreeFollowsService, private readonly treeFollows: TreeFollowsService,
private readonly reminders: IssueRemindersService, private readonly reminders: IssueRemindersService,
private readonly myDayService: MyDayService, private readonly myDayService: MyDayService,
private readonly visits: IssueVisitsService,
) {} ) {}
@Get('me/home') @Get('me/home')
@@ -382,6 +385,27 @@ export class IssuesController {
); );
} }
@Put('issues/:issue/visit')
@ISSUE
@ApiOperation({
summary: 'I opened this ticket now',
description:
'Answers when I had opened it before (null: never), to show what others did since. Private to me.',
})
@ApiOkResponse({ type: IssueVisitDto })
@ApiCommandErrors()
async visit(
@CurrentUser() me: User,
@Param('issue') issue: string,
): Promise<IssueVisitDto> {
return {
previousVisit: await this.visits.visit(
me.id,
await this.refs.issueId(me.id, issue),
),
};
}
@Put('issues/:issue/follow-tree') @Put('issues/:issue/follow-tree')
@HttpCode(204) @HttpCode(204)
@ISSUE @ISSUE

View File

@@ -110,6 +110,12 @@ export const issuePageEvents = eventGroup({
resolved: boolean; resolved: boolean;
conclusion: string | null; conclusion: string | null;
}>(), }>(),
commentToIssueRequested: type<{
commentId: string;
title: string;
type: string;
asSubtask: boolean;
}>(),
voteRequested: type<{ issueId: string; on: boolean }>(), voteRequested: type<{ issueId: string; on: boolean }>(),
/** An image pasted into a text was uploaded (it joins the ticket's files). */ /** An image pasted into a text was uploaded (it joins the ticket's files). */
imagePasted: type<{ issueId: string }>(), imagePasted: type<{ issueId: string }>(),

View File

@@ -316,6 +316,21 @@ export class IssueFacade {
}); });
} }
/** Makes a ticket of a comment: a subtask of this one, or linked to it. */
turnCommentIntoIssue(
commentId: string,
title: string,
type: string,
asSubtask: boolean,
): void {
this.dispatch.commentToIssueRequested({
commentId,
title: title.trim(),
type,
asSubtask,
});
}
/** Marks a comment as a decision of the ticket (`on`) or unmarks it. */ /** Marks a comment as a decision of the ticket (`on`) or unmarks it. */
markDecision(commentId: string, on: boolean): void { markDecision(commentId: string, on: boolean): void {
this.dispatch.decisionRequested({ commentId, on }); this.dispatch.decisionRequested({ commentId, on });

View File

@@ -608,6 +608,28 @@ export const IssueStore = signalStore(
), ),
), ),
), ),
events.on(issuePageEvents.commentToIssueRequested).pipe(
mergeMap(({ payload }) =>
comments
.turnIntoIssue(
payload.commentId,
payload.title,
payload.type,
payload.asSubtask,
)
.pipe(
mapResponse({
next: (result) =>
done(
result.key
? `Creado ${result.key}`
: 'Ticket creado',
),
error: (error) => failed(describeError(error)),
}),
),
),
),
events.on(issuePageEvents.reactRequested).pipe( events.on(issuePageEvents.reactRequested).pipe(
mergeMap(({ payload }) => mergeMap(({ payload }) =>
comments.react(payload.commentId, payload.emoji, payload.on).pipe( comments.react(payload.commentId, payload.emoji, payload.on).pipe(

View File

@@ -4,6 +4,7 @@ export * from './lib/models/bulk';
export * from './lib/models/reminders'; export * from './lib/models/reminders';
export * from './lib/models/my-day'; export * from './lib/models/my-day';
export * from './lib/models/health'; export * from './lib/models/health';
export * from './lib/models/news';
export * from './lib/models/inputs'; export * from './lib/models/inputs';
export * from './lib/models/workflow'; export * from './lib/models/workflow';
export * from './lib/ports/gateways'; export * from './lib/ports/gateways';

View File

@@ -385,6 +385,8 @@ export interface Comment {
resolved: boolean; resolved: boolean;
/** Who settled it (null while open). */ /** Who settled it (null while open). */
resolvedBy: UserRef | null; resolvedBy: UserRef | null;
/** Tickets made from it («Convertir en ticket»), oldest first. */
spawned: { id: string; key: string }[];
createdAt: string; createdAt: string;
editedAt: string | null; editedAt: string | null;
} }

View File

@@ -0,0 +1,86 @@
import { Activity, Comment } from './models';
import { newsSince, titleFrom } from './news';
const user = (id: string, name: string) => ({ id, name });
const comment = (
id: string,
by: string,
at: string,
deleted = false,
): Comment =>
({
id,
author: user(by, by === 'me' ? 'Yo' : by === 'ana' ? 'Ana' : 'Bob'),
createdAt: at,
deleted,
}) as Comment;
const change = (id: string, by: string, at: string, type: string): Activity =>
({
id,
type,
actor: user(by, by === 'ana' ? 'Ana' : 'Bob'),
occurredAt: at,
}) as Activity;
describe('news since my last visit', () => {
const since = '2026-10-20T10:00:00.000Z';
it('counts what others did since, not mine nor what came before', () => {
const news = newsSince(
[
comment('old', 'ana', '2026-10-19T09:00:00.000Z'),
comment('mine', 'me', '2026-10-21T09:00:00.000Z'),
comment('c1', 'bob', '2026-10-21T09:30:00.000Z'),
comment('gone', 'ana', '2026-10-21T09:40:00.000Z', true),
comment('c2', 'ana', '2026-10-21T10:00:00.000Z'),
],
[
change(
'h1',
'ana',
'2026-10-21T08:00:00.000Z',
'IssueStatusChangedEvent',
),
// The comment itself is already counted as a comment.
change('h2', 'bob', '2026-10-21T09:30:00.000Z', 'CommentAddedEvent'),
change('h3', 'bob', '2026-10-19T08:00:00.000Z', 'IssueAssignedEvent'),
],
since,
'me',
);
expect(news).toEqual({
since,
what: '2 comentarios y 1 cambio',
who: 'Bob y Ana',
firstComment: 'c1',
});
});
it('says nothing the first time, or when nothing happened', () => {
const comments = [comment('c1', 'ana', '2026-10-21T09:00:00.000Z')];
expect(newsSince(comments, [], null, 'me')).toBeNull();
expect(
newsSince(comments, [], '2026-10-22T00:00:00.000Z', 'me'),
).toBeNull();
});
});
describe('titleFrom', () => {
it('takes the first line without Markdown', () => {
expect(
titleFrom(
'\n## También falla en **Android** ([log](https://x.dev))\nMás',
),
).toBe('También falla en Android (log)');
expect(titleFrom('- `npm ci` rompe en CI')).toBe('npm ci rompe en CI');
expect(titleFrom('También falla en Android.\nAdjunto el log.')).toBe(
'También falla en Android',
);
});
it('cuts long lines at a word', () => {
const title = titleFrom('palabra '.repeat(30));
expect(title.length).toBeLessThanOrEqual(121);
expect(title.endsWith('palabra…')).toBe(true);
});
});

View File

@@ -0,0 +1,102 @@
import { Activity, Comment } from './models';
/*
* «Lo nuevo desde tu última visita»: what others did on a ticket since I
* last opened it. My own comments and changes are not news to me.
*/
/** A comment someone else wrote since (deleted ones say nothing). */
export function isNewComment(
comment: Comment,
since: string | null,
me: string | null,
): boolean {
return (
!!since &&
!comment.deleted &&
comment.createdAt > since &&
comment.author.id !== me
);
}
/** A change someone else made since; comments count on their own. */
export function isNewChange(
entry: Activity,
since: string | null,
me: string | null,
): boolean {
return (
!!since &&
entry.occurredAt > since &&
entry.actor.id !== me &&
!entry.type.startsWith('Comment')
);
}
export interface IssueNews {
since: string;
/** «2 comentarios y 1 cambio». */
what: string;
/** «Ana y Bob». */
who: string;
/** The first new comment, to go to it. */
firstComment: string | null;
}
/** What is new since, or null when nothing is (or it is my first time). */
export function newsSince(
comments: Comment[],
history: Activity[],
since: string | null,
me: string | null,
): IssueNews | null {
if (!since) return null;
const fresh = comments.filter((c) => isNewComment(c, since, me));
const changes = history.filter((e) => isNewChange(e, since, me));
if (!fresh.length && !changes.length) return null;
const what = [
count(fresh.length, 'comentario', 'comentarios'),
count(changes.length, 'cambio', 'cambios'),
].filter(Boolean);
const who = [
...new Set([
...fresh.map((c) => c.author.name),
...changes.map((e) => e.actor.name),
]),
];
return {
since,
what: what.join(' y '),
who:
who.length > 1
? `${who.slice(0, -1).join(', ')} y ${who[who.length - 1]}`
: who[0],
firstComment: fresh[0]?.id ?? null,
};
}
function count(n: number, one: string, many: string): string {
return n === 1 ? `1 ${one}` : n ? `${n} ${many}` : '';
}
/** A ticket title out of a comment: its first line, without Markdown. */
export function titleFrom(body: string): string {
const line =
body
.split('\n')
.map((l) =>
l
.replace(/!\[[^\]]*\]\([^)]*\)/g, '')
.replace(/\[([^\]]*)\]\([^)]*\)/g, '$1')
.replace(/^\s*(#+|>|[-*+]|\d+\.)\s*/, '')
.replace(/[*_`~]/g, '')
.trim()
// A title ends without the sentence's stop.
.replace(/[.:;,]+$/, ''),
)
.find(Boolean) ?? '';
if (line.length <= 120) return line;
const cut = line.slice(0, 120);
const space = cut.lastIndexOf(' ');
return `${space > 60 ? cut.slice(0, space) : cut}…`;
}

View File

@@ -170,6 +170,8 @@ export abstract class IssuesGateway {
abstract pin(issueId: string, pinned: boolean): Observable<void>; abstract pin(issueId: string, pinned: boolean): Observable<void>;
/** Follows the ticket with everything under it (or stops). */ /** Follows the ticket with everything under it (or stops). */
abstract followTree(issueId: string, on: boolean): Observable<void>; abstract followTree(issueId: string, on: boolean): Observable<void>;
/** I opened it now: answers my visit before (null: never). */
abstract visit(issueId: string): Observable<string | null>;
/** Reminds me of the ticket then (replaces the waiting one). */ /** Reminds me of the ticket then (replaces the waiting one). */
abstract setReminder( abstract setReminder(
issueId: string, issueId: string,
@@ -368,6 +370,13 @@ export abstract class CommentsGateway {
resolved: boolean, resolved: boolean,
conclusion: string | null, conclusion: string | null,
): Observable<CommandResult>; ): Observable<CommandResult>;
/** Makes a ticket of it: a subtask of its ticket, or linked. Answers the new one. */
abstract turnIntoIssue(
commentId: string,
title: string,
type: string,
asSubtask: boolean,
): Observable<CommandResult>;
/** Marks it as a decision of its ticket (`on`) or unmarks it. */ /** Marks it as a decision of its ticket (`on`) or unmarks it. */
abstract markDecision( abstract markDecision(
commentId: string, commentId: string,

View File

@@ -25,6 +25,7 @@ import {
ReactToCommentDocument, ReactToCommentDocument,
MarkDecisionDocument, MarkDecisionDocument,
ResolveThreadDocument, ResolveThreadDocument,
TurnCommentIntoIssueDocument,
VotePollDocument, VotePollDocument,
ClosePollDocument, ClosePollDocument,
PublishReleaseDocument, PublishReleaseDocument,
@@ -111,6 +112,22 @@ export class GraphqlCommentsGateway extends CommentsGateway {
.pipe(map((d) => toCommandResult(d.resolveThread))); .pipe(map((d) => toCommandResult(d.resolveThread)));
} }
turnIntoIssue(
commentId: string,
title: string,
type: string,
asSubtask: boolean,
): Observable<CommandResult> {
return this.gql
.mutate(TurnCommentIntoIssueDocument, {
commentId,
title,
type,
asSubtask,
})
.pipe(map((d) => toCommandResult(d.turnCommentIntoIssue)));
}
markDecision(commentId: string, on: boolean): Observable<CommandResult> { markDecision(commentId: string, on: boolean): Observable<CommandResult> {
return this.gql return this.gql
.mutate(MarkDecisionDocument, { commentId, on }) .mutate(MarkDecisionDocument, { commentId, on })

View File

@@ -57,6 +57,7 @@ import {
CancelReviewDocument, CancelReviewDocument,
MyPinsDocument, MyPinsDocument,
FollowTreeDocument, FollowTreeDocument,
VisitIssueDocument,
SetReminderDocument, SetReminderDocument,
MyDayDocument, MyDayDocument,
AddToMyDayDocument, AddToMyDayDocument,
@@ -272,6 +273,12 @@ export class GraphqlIssuesGateway extends IssuesGateway {
.pipe(map(() => undefined)); .pipe(map(() => undefined));
} }
visit(issueId: string): Observable<string | null> {
return this.gql
.mutate(VisitIssueDocument, { issueId })
.pipe(map((d) => d.visitIssue ?? null));
}
followTree(issueId: string, on: boolean): Observable<void> { followTree(issueId: string, on: boolean): Observable<void> {
const done$: Observable<unknown> = on const done$: Observable<unknown> = on
? this.gql.mutate(FollowTreeDocument, { issueId }) ? this.gql.mutate(FollowTreeDocument, { issueId })

View File

@@ -218,6 +218,10 @@ fragment CommentFields on Comment {
resolvedBy { resolvedBy {
...UserRefFields ...UserRefFields
} }
spawned {
id
key
}
createdAt createdAt
editedAt editedAt
author { author {

View File

@@ -754,6 +754,7 @@ export type IssueFieldsFragment = {
}>; }>;
} | null; } | null;
resolvedBy: { id: string; name: string } | null; resolvedBy: { id: string; name: string } | null;
spawned: Array<{ id: string; key: string }>;
author: { id: string; name: string }; author: { id: string; name: string };
}>; }>;
reporter: { id: string; name: string }; reporter: { id: string; name: string };
@@ -817,6 +818,7 @@ export type CommentFieldsFragment = {
}>; }>;
} | null; } | null;
resolvedBy: { id: string; name: string } | null; resolvedBy: { id: string; name: string } | null;
spawned: Array<{ id: string; key: string }>;
author: { id: string; name: string }; author: { id: string; name: string };
}; };
@@ -1027,6 +1029,7 @@ export type IssueQuery = {
}>; }>;
} | null; } | null;
resolvedBy: { id: string; name: string } | null; resolvedBy: { id: string; name: string } | null;
spawned: Array<{ id: string; key: string }>;
author: { id: string; name: string }; author: { id: string; name: string };
}>; }>;
reporter: { id: string; name: string }; reporter: { id: string; name: string };
@@ -1398,6 +1401,7 @@ export type IssueCommentsQuery = {
}>; }>;
} | null; } | null;
resolvedBy: { id: string; name: string } | null; resolvedBy: { id: string; name: string } | null;
spawned: Array<{ id: string; key: string }>;
author: { id: string; name: string }; author: { id: string; name: string };
}>; }>;
}; };
@@ -1830,6 +1834,23 @@ export type ResolveThreadMutation = {
resolveThread: { id: string; key: string | null; version: number }; resolveThread: { id: string; key: string | null; version: number };
}; };
export type TurnCommentIntoIssueMutationVariables = Exact<{
commentId: string;
title: string;
type: string;
asSubtask: boolean;
}>;
export type TurnCommentIntoIssueMutation = {
turnCommentIntoIssue: { id: string; key: string | null; version: number };
};
export type VisitIssueMutationVariables = Exact<{
issueId: string;
}>;
export type VisitIssueMutation = { visitIssue: string | null };
export type MarkDecisionMutationVariables = Exact<{ export type MarkDecisionMutationVariables = Exact<{
commentId: string; commentId: string;
on: boolean; on: boolean;
@@ -1870,6 +1891,7 @@ export type SearchDecisionsQuery = {
}>; }>;
} | null; } | null;
resolvedBy: { id: string; name: string } | null; resolvedBy: { id: string; name: string } | null;
spawned: Array<{ id: string; key: string }>;
author: { id: string; name: string }; author: { id: string; name: string };
}; };
issue: { id: string; key: string; title: string }; issue: { id: string; key: string; title: string };
@@ -3254,6 +3276,7 @@ export type CommentChangedSubscription = {
}>; }>;
} | null; } | null;
resolvedBy: { id: string; name: string } | null; resolvedBy: { id: string; name: string } | null;
spawned: Array<{ id: string; key: string }>;
author: { id: string; name: string }; author: { id: string; name: string };
} | null; } | null;
}; };
@@ -4091,6 +4114,17 @@ export const CommentFieldsFragmentDoc = {
], ],
}, },
}, },
{
kind: 'Field',
name: { kind: 'Name', value: 'spawned' },
selectionSet: {
kind: 'SelectionSet',
selections: [
{ kind: 'Field', name: { kind: 'Name', value: 'id' } },
{ kind: 'Field', name: { kind: 'Name', value: 'key' } },
],
},
},
{ kind: 'Field', name: { kind: 'Name', value: 'createdAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'createdAt' } },
{ kind: 'Field', name: { kind: 'Name', value: 'editedAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'editedAt' } },
{ {
@@ -4536,6 +4570,17 @@ export const IssueFieldsFragmentDoc = {
], ],
}, },
}, },
{
kind: 'Field',
name: { kind: 'Name', value: 'spawned' },
selectionSet: {
kind: 'SelectionSet',
selections: [
{ kind: 'Field', name: { kind: 'Name', value: 'id' } },
{ kind: 'Field', name: { kind: 'Name', value: 'key' } },
],
},
},
{ kind: 'Field', name: { kind: 'Name', value: 'createdAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'createdAt' } },
{ kind: 'Field', name: { kind: 'Name', value: 'editedAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'editedAt' } },
{ {
@@ -6853,6 +6898,17 @@ export const IssueDocument = {
], ],
}, },
}, },
{
kind: 'Field',
name: { kind: 'Name', value: 'spawned' },
selectionSet: {
kind: 'SelectionSet',
selections: [
{ kind: 'Field', name: { kind: 'Name', value: 'id' } },
{ kind: 'Field', name: { kind: 'Name', value: 'key' } },
],
},
},
{ kind: 'Field', name: { kind: 'Name', value: 'createdAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'createdAt' } },
{ kind: 'Field', name: { kind: 'Name', value: 'editedAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'editedAt' } },
{ {
@@ -9204,6 +9260,17 @@ export const IssueCommentsDocument = {
], ],
}, },
}, },
{
kind: 'Field',
name: { kind: 'Name', value: 'spawned' },
selectionSet: {
kind: 'SelectionSet',
selections: [
{ kind: 'Field', name: { kind: 'Name', value: 'id' } },
{ kind: 'Field', name: { kind: 'Name', value: 'key' } },
],
},
},
{ kind: 'Field', name: { kind: 'Name', value: 'createdAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'createdAt' } },
{ kind: 'Field', name: { kind: 'Name', value: 'editedAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'editedAt' } },
{ {
@@ -12014,6 +12081,181 @@ export const ResolveThreadDocument = {
ResolveThreadMutation, ResolveThreadMutation,
ResolveThreadMutationVariables ResolveThreadMutationVariables
>; >;
export const TurnCommentIntoIssueDocument = {
kind: 'Document',
definitions: [
{
kind: 'OperationDefinition',
operation: 'mutation',
name: { kind: 'Name', value: 'TurnCommentIntoIssue' },
variableDefinitions: [
{
kind: 'VariableDefinition',
variable: {
kind: 'Variable',
name: { kind: 'Name', value: 'commentId' },
},
type: {
kind: 'NonNullType',
type: { kind: 'NamedType', name: { kind: 'Name', value: 'ID' } },
},
},
{
kind: 'VariableDefinition',
variable: {
kind: 'Variable',
name: { kind: 'Name', value: 'title' },
},
type: {
kind: 'NonNullType',
type: {
kind: 'NamedType',
name: { kind: 'Name', value: 'String' },
},
},
},
{
kind: 'VariableDefinition',
variable: { kind: 'Variable', name: { kind: 'Name', value: 'type' } },
type: {
kind: 'NonNullType',
type: {
kind: 'NamedType',
name: { kind: 'Name', value: 'String' },
},
},
},
{
kind: 'VariableDefinition',
variable: {
kind: 'Variable',
name: { kind: 'Name', value: 'asSubtask' },
},
type: {
kind: 'NonNullType',
type: {
kind: 'NamedType',
name: { kind: 'Name', value: 'Boolean' },
},
},
},
],
selectionSet: {
kind: 'SelectionSet',
selections: [
{
kind: 'Field',
name: { kind: 'Name', value: 'turnCommentIntoIssue' },
arguments: [
{
kind: 'Argument',
name: { kind: 'Name', value: 'commentId' },
value: {
kind: 'Variable',
name: { kind: 'Name', value: 'commentId' },
},
},
{
kind: 'Argument',
name: { kind: 'Name', value: 'title' },
value: {
kind: 'Variable',
name: { kind: 'Name', value: 'title' },
},
},
{
kind: 'Argument',
name: { kind: 'Name', value: 'type' },
value: {
kind: 'Variable',
name: { kind: 'Name', value: 'type' },
},
},
{
kind: 'Argument',
name: { kind: 'Name', value: 'asSubtask' },
value: {
kind: 'Variable',
name: { kind: 'Name', value: 'asSubtask' },
},
},
],
selectionSet: {
kind: 'SelectionSet',
selections: [
{
kind: 'FragmentSpread',
name: { kind: 'Name', value: 'CommandResultFields' },
},
],
},
},
],
},
},
{
kind: 'FragmentDefinition',
name: { kind: 'Name', value: 'CommandResultFields' },
typeCondition: {
kind: 'NamedType',
name: { kind: 'Name', value: 'CommandResult' },
},
selectionSet: {
kind: 'SelectionSet',
selections: [
{ kind: 'Field', name: { kind: 'Name', value: 'id' } },
{ kind: 'Field', name: { kind: 'Name', value: 'key' } },
{ kind: 'Field', name: { kind: 'Name', value: 'version' } },
],
},
},
],
} as unknown as DocumentNode<
TurnCommentIntoIssueMutation,
TurnCommentIntoIssueMutationVariables
>;
export const VisitIssueDocument = {
kind: 'Document',
definitions: [
{
kind: 'OperationDefinition',
operation: 'mutation',
name: { kind: 'Name', value: 'VisitIssue' },
variableDefinitions: [
{
kind: 'VariableDefinition',
variable: {
kind: 'Variable',
name: { kind: 'Name', value: 'issueId' },
},
type: {
kind: 'NonNullType',
type: { kind: 'NamedType', name: { kind: 'Name', value: 'ID' } },
},
},
],
selectionSet: {
kind: 'SelectionSet',
selections: [
{
kind: 'Field',
name: { kind: 'Name', value: 'visitIssue' },
arguments: [
{
kind: 'Argument',
name: { kind: 'Name', value: 'issueId' },
value: {
kind: 'Variable',
name: { kind: 'Name', value: 'issueId' },
},
},
],
},
],
},
},
],
} as unknown as DocumentNode<VisitIssueMutation, VisitIssueMutationVariables>;
export const MarkDecisionDocument = { export const MarkDecisionDocument = {
kind: 'Document', kind: 'Document',
definitions: [ definitions: [
@@ -12304,6 +12546,17 @@ export const SearchDecisionsDocument = {
], ],
}, },
}, },
{
kind: 'Field',
name: { kind: 'Name', value: 'spawned' },
selectionSet: {
kind: 'SelectionSet',
selections: [
{ kind: 'Field', name: { kind: 'Name', value: 'id' } },
{ kind: 'Field', name: { kind: 'Name', value: 'key' } },
],
},
},
{ kind: 'Field', name: { kind: 'Name', value: 'createdAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'createdAt' } },
{ kind: 'Field', name: { kind: 'Name', value: 'editedAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'editedAt' } },
{ {
@@ -19548,6 +19801,17 @@ export const CommentChangedDocument = {
], ],
}, },
}, },
{
kind: 'Field',
name: { kind: 'Name', value: 'spawned' },
selectionSet: {
kind: 'SelectionSet',
selections: [
{ kind: 'Field', name: { kind: 'Name', value: 'id' } },
{ kind: 'Field', name: { kind: 'Name', value: 'key' } },
],
},
},
{ kind: 'Field', name: { kind: 'Name', value: 'createdAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'createdAt' } },
{ kind: 'Field', name: { kind: 'Name', value: 'editedAt' } }, { kind: 'Field', name: { kind: 'Name', value: 'editedAt' } },
{ {

View File

@@ -396,6 +396,26 @@ mutation ResolveThread(
} }
} }
mutation TurnCommentIntoIssue(
$commentId: ID!
$title: String!
$type: String!
$asSubtask: Boolean!
) {
turnCommentIntoIssue(
commentId: $commentId
title: $title
type: $type
asSubtask: $asSubtask
) {
...CommandResultFields
}
}
mutation VisitIssue($issueId: ID!) {
visitIssue(issueId: $issueId)
}
mutation MarkDecision($commentId: ID!, $on: Boolean!) { mutation MarkDecision($commentId: ID!, $on: Boolean!) {
markDecision(commentId: $commentId, on: $on) { markDecision(commentId: $commentId, on: $on) {
...CommandResultFields ...CommandResultFields

View File

@@ -339,6 +339,60 @@ a.ts-key {
background: color-mix(in srgb, var(--ts-c-green) 6%, transparent); background: color-mix(in srgb, var(--ts-c-green) 6%, transparent);
} }
/* Written by someone else since my last visit. */
.ts-comment.is-new:not(.is-decision) {
margin-inline: -0.75rem;
padding-inline: 0.75rem;
border-left: 3px solid var(--ts-brand);
background: color-mix(in srgb, var(--ts-brand) 5%, transparent);
}
.ts-comment__new {
padding: 0.0625rem 0.5rem;
border-radius: 999px;
background: color-mix(in srgb, var(--ts-brand) 14%, transparent);
color: var(--ts-brand);
font-size: 0.6875rem;
font-weight: 700;
letter-spacing: 0.04em;
text-transform: uppercase;
}
/* «→ Convertido en WEB-45». */
.ts-comment__spawned {
display: flex;
flex-wrap: wrap;
gap: 0.25rem 0.5rem;
margin: 0.375rem 0 0;
color: var(--ts-muted);
font-size: 0.8125rem;
a {
font-family: var(--ts-font-mono);
font-weight: 600;
}
}
/* What others did since my last visit, above the ticket. */
.ts-news {
display: flex;
flex-wrap: wrap;
align-items: center;
gap: 0.25rem 0.625rem;
margin: 0;
padding: 0.5rem 0.875rem;
border-radius: 0.625rem;
background: color-mix(in srgb, var(--ts-brand) 9%, transparent);
font-size: 0.875rem;
}
.ts-news__dot {
width: 0.5rem;
height: 0.5rem;
border-radius: 50%;
background: var(--ts-brand);
}
.ts-comment.is-pointed { .ts-comment.is-pointed {
animation: ts-pointed 2.4s ease-out; animation: ts-pointed 2.4s ease-out;
} }
@@ -469,6 +523,23 @@ a.ts-key {
&:last-child { &:last-child {
border-bottom: 0; border-bottom: 0;
} }
/* Changed by someone else since my last visit. */
&.is-new .ts-log__what {
color: var(--ts-ink);
font-weight: 600;
}
&.is-new .ts-log__when::before {
content: '';
display: inline-block;
width: 0.375rem;
height: 0.375rem;
margin-right: 0.375rem;
border-radius: 50%;
background: var(--ts-brand);
vertical-align: middle;
}
} }
} }

View File

@@ -25,6 +25,7 @@ import {
PiIconComponent, PiIconComponent,
PiLabelDirective, PiLabelDirective,
PiNoteComponent, PiNoteComponent,
PiSegmentedControlComponent,
PiProgressBarComponent, PiProgressBarComponent,
PiSearchableSelectFieldComponent, PiSearchableSelectFieldComponent,
PiSelectFieldComponent, PiSelectFieldComponent,
@@ -44,7 +45,12 @@ import {
} from '@task-stream/web/tracker/application'; } from '@task-stream/web/tracker/application';
import { import {
Attachment, Attachment,
Activity,
Comment, Comment,
isNewChange,
isNewComment,
newsSince,
titleFrom,
CommentPoll, CommentPoll,
DevLink, DevLink,
Issue, Issue,
@@ -113,6 +119,7 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
PiIconButtonComponent, PiIconButtonComponent,
PiLabelDirective, PiLabelDirective,
PiNoteComponent, PiNoteComponent,
PiSegmentedControlComponent,
PiProgressBarComponent, PiProgressBarComponent,
PiSearchableSelectFieldComponent, PiSearchableSelectFieldComponent,
PiSelectFieldComponent, PiSelectFieldComponent,
@@ -337,6 +344,27 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
</p> </p>
} }
@if (news(); as news) {
<p class="ts-news" role="status">
<span class="ts-news__dot" aria-hidden="true"></span>
<span
>Desde tu última visita, {{ ago(news.since) }}:
<strong>{{ news.what }}</strong> de {{ news.who }}.</span
>
@if (news.firstComment; as first) {
<span class="ts-reminder__actions">
<pi-action-button
size="x-small"
color="grey"
appearance="outline"
text="Ver lo nuevo"
(execute)="goToNews(first)"
/>
</span>
}
</p>
}
@if (project.canContribute() && issue.allowedTransitions.length) { @if (project.canContribute() && issue.allowedTransitions.length) {
<div class="ts-transitions" role="group" aria-label="Mover a"> <div class="ts-transitions" role="group" aria-label="Mover a">
<span class="ts-eyebrow">Mover a</span> <span class="ts-eyebrow">Mover a</span>
@@ -852,6 +880,7 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
class="ts-comment" class="ts-comment"
[id]="'comment-' + comment.id" [id]="'comment-' + comment.id"
[class.is-decision]="comment.decision && !comment.deleted" [class.is-decision]="comment.decision && !comment.deleted"
[class.is-new]="isNew(comment)"
> >
<span class="ts-comment__avatar" aria-hidden="true">{{ <span class="ts-comment__avatar" aria-hidden="true">{{
initialsOf(comment.author.name) initialsOf(comment.author.name)
@@ -868,6 +897,9 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
@if (comment.decision && !comment.deleted) { @if (comment.decision && !comment.deleted) {
<span class="ts-comment__decision">Decisión</span> <span class="ts-comment__decision">Decisión</span>
} }
@if (isNew(comment)) {
<span class="ts-comment__new">Nuevo</span>
}
<span class="ts-spacer"></span> <span class="ts-spacer"></span>
@if (!comment.deleted && project.canContribute()) { @if (!comment.deleted && project.canContribute()) {
<!-- Native: pi-icon-button leaves its button unnamed. --> <!-- Native: pi-icon-button leaves its button unnamed. -->
@@ -893,6 +925,18 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
<pi-icon icon="flag" size="small" /> <pi-icon icon="flag" size="small" />
</button> </button>
} }
@if (!comment.deleted && project.canContribute()) {
<!-- Native, like the flag: a named button. -->
<button
type="button"
class="ts-comment__flag"
aria-label="Convertir en ticket"
title="Convertir en ticket: su texto será la descripción"
(click)="openTurnIntoIssue(comment)"
>
<pi-icon icon="task" size="small" />
</button>
}
@if ( @if (
!comment.deleted && comment.author.id === facade.me() !comment.deleted && comment.author.id === facade.me()
) { ) {
@@ -925,6 +969,16 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
[me]="facade.me()" [me]="facade.me()"
[loader]="loadImage" [loader]="loadImage"
/> />
@if (comment.spawned.length) {
<p class="ts-comment__spawned">
<span aria-hidden="true">→</span> Convertido en
@for (spawn of comment.spawned; track spawn.id) {
<a [routerLink]="['..', spawn.key]">{{
spawn.key
}}</a>
}
</p>
}
} }
@if (!comment.deleted && comment.poll; as poll) { @if (!comment.deleted && comment.poll; as poll) {
<div <div
@@ -1044,6 +1098,12 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
: '' : ''
}}</span }}</span
> >
@if (newIn(thread); as count) {
<span class="ts-comment__new"
>{{ count }}
{{ count === 1 ? 'nuevo' : 'nuevos' }}</span
>
}
</div> </div>
<button <button
type="button" type="button"
@@ -1304,7 +1364,7 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
<h2 class="ts-section">Historial</h2> <h2 class="ts-section">Historial</h2>
<ol class="ts-log"> <ol class="ts-log">
@for (entry of facade.history(); track entry.id) { @for (entry of facade.history(); track entry.id) {
<li> <li [class.is-new]="isNewChange(entry)">
<time <time
class="ts-log__when" class="ts-log__when"
[attr.datetime]="entry.occurredAt" [attr.datetime]="entry.occurredAt"
@@ -1451,6 +1511,41 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
<pi-skeleton shape="text" [lines]="8" /> <pi-skeleton shape="text" [lines]="8" />
} }
<ng-template #turnIntoIssueForm>
<form
class="ts-form"
(submit)="$event.preventDefault(); sendTurnIntoIssue()"
novalidate
>
<p class="ts-muted">
El texto del comentario será la descripción, y el comentario enlazará
al ticket nuevo.
</p>
<pi-text-field [(value)]="spawnTitle">
<pi-label [isRequired]="true">Título</pi-label>
</pi-text-field>
<pi-select-field
[options]="subtaskTypeOptions()"
[value]="spawnType()"
(valueChange)="spawnType.set($event ?? '')"
>
<pi-label>Tipo</pi-label>
</pi-select-field>
<pi-segmented-control
ariaLabel="Cómo queda"
[options]="spawnModes()"
[(value)]="spawnMode"
/>
<pi-action-button
size="w100"
color="primary"
text="Crear ticket"
[disabled]="!spawnTitle().trim() || !spawnType()"
(execute)="sendTurnIntoIssue()"
/>
</form>
</ng-template>
<ng-template #reviewRequestForm> <ng-template #reviewRequestForm>
<form <form
class="ts-form" class="ts-form"
@@ -1673,6 +1768,20 @@ export class IssuePage {
viewChild.required<TemplateRef<unknown>>('reasonForm'); viewChild.required<TemplateRef<unknown>>('reasonForm');
private readonly reminderForm = private readonly reminderForm =
viewChild.required<TemplateRef<unknown>>('reminderForm'); viewChild.required<TemplateRef<unknown>>('reminderForm');
private readonly turnIntoIssueForm =
viewChild.required<TemplateRef<unknown>>('turnIntoIssueForm');
/** «Convertir en ticket»: the comment, and the ticket being made of it. */
private readonly spawnFrom = signal<Comment | null>(null);
protected readonly spawnTitle = signal('');
protected readonly spawnType = signal('');
protected readonly spawnMode = signal<'link' | 'subtask'>('link');
protected readonly spawnModes = computed(() => {
const key = this.facade.issue()?.key ?? 'este';
return [
{ value: 'link' as const, label: `Enlazado a ${key}` },
{ value: 'subtask' as const, label: `Subtarea de ${key}` },
];
});
private readonly reviewRequestForm = private readonly reviewRequestForm =
viewChild.required<TemplateRef<unknown>>('reviewRequestForm'); viewChild.required<TemplateRef<unknown>>('reviewRequestForm');
private readonly reviewAnswerForm = private readonly reviewAnswerForm =
@@ -2024,6 +2133,17 @@ export class IssuePage {
if (id && this.facade.comments().some((c) => c.id === id)) if (id && this.facade.comments().some((c) => c.id === id))
untracked(() => setTimeout(() => this.goToComment(id))); untracked(() => setTimeout(() => this.goToComment(id)));
}); });
// My visit before this one, once per ticket (only with a session).
effect(() => {
const issueId = this.openIssueId();
if (!issueId || !this.facade.me()) return;
untracked(() =>
this.issuesGateway.visit(issueId).subscribe({
next: (since) => this.visit.set({ issueId, since }),
error: () => this.visit.set(null),
}),
);
});
// Whether it is in today's «Mi día», once per ticket. // Whether it is in today's «Mi día», once per ticket.
effect(() => { effect(() => {
const issueId = this.openIssueId(); const issueId = this.openIssueId();
@@ -2106,6 +2226,65 @@ export class IssuePage {
protected readonly inMyDay = signal<boolean | null>(null); protected readonly inMyDay = signal<boolean | null>(null);
/** Changes with the ticket, not with each reload of it. */ /** Changes with the ticket, not with each reload of it. */
private readonly openIssueId = computed(() => this.facade.issue()?.id); private readonly openIssueId = computed(() => this.facade.issue()?.id);
/* «Lo nuevo desde tu última visita»: what others did since I last came. */
private readonly visit = signal<{
issueId: string;
since: string | null;
} | null>(null);
private readonly since = computed(() => {
const visit = this.visit();
return visit && visit.issueId === this.openIssueId() ? visit.since : null;
});
protected isNew(comment: Comment): boolean {
return isNewComment(comment, this.since(), this.facade.me());
}
protected isNewChange(entry: Activity): boolean {
return isNewChange(entry, this.since(), this.facade.me());
}
protected newIn(thread: { comment: Comment; replies: Comment[] }): number {
return [thread.comment, ...thread.replies].filter((c) => this.isNew(c))
.length;
}
protected readonly news = computed(() =>
newsSince(
this.facade.comments(),
this.facade.history(),
this.since(),
this.facade.me(),
),
);
/** To the first new comment, unfolding its conversation if settled. */
protected goToNews(commentId: string): void {
const thread = this.threads().find(
(t) =>
t.comment.id === commentId || t.replies.some((r) => r.id === commentId),
);
if (thread?.comment.resolved && !this.expanded().has(thread.comment.id))
this.toggleThread(thread.comment.id);
setTimeout(() => this.goToComment(commentId));
}
protected openTurnIntoIssue(comment: Comment): void {
this.spawnFrom.set(comment);
this.spawnTitle.set(titleFrom(comment.body));
this.spawnType.set(this.defaultSubtaskType());
this.spawnMode.set('link');
this.drawer.open('Convertir en ticket', this.turnIntoIssueForm());
}
protected sendTurnIntoIssue(): void {
const comment = this.spawnFrom();
if (!comment || !this.spawnTitle().trim() || !this.spawnType()) return;
this.facade.turnCommentIntoIssue(
comment.id,
this.spawnTitle(),
this.spawnType(),
this.spawnMode() === 'subtask',
);
this.drawer.closeAll();
}
private readonly issuesGateway = inject(IssuesGateway); private readonly issuesGateway = inject(IssuesGateway);
protected toggleMyDay(issue: Issue): void { protected toggleMyDay(issue: Issue): void {