feat: steadier live updates and notices for public proposals
- The web pings the live connection, reconnects when it goes quiet and reloads what each screen shows after reconnecting. - Dropping a card on a column it cannot go to puts it back. - Owners and admins get a notice when a proposal arrives. - The proposal limit lives in Redis, so it holds across instances. - REST tells whether I voted; pasted images leave the attachment list. - Deleting a project removes its Git integration; no lint warnings left. - Reactions and the blocked badge are components of their own. - Docs: what is done and what is left (chapter 10), Word and PDF. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -49,7 +49,6 @@ import {
|
||||
mentionQuery,
|
||||
POINT_SCALE,
|
||||
ReleaseStatus,
|
||||
REACTIONS,
|
||||
} from '@task-stream/web/tracker/domain';
|
||||
import {
|
||||
clock,
|
||||
@@ -63,6 +62,8 @@ import {
|
||||
typeLook,
|
||||
} from '../ui/copy';
|
||||
import { AttachmentItem } from '../ui/attachments';
|
||||
import { BlockedComponent } from '../ui/blocked';
|
||||
import { ReactionsComponent } from '../ui/reactions';
|
||||
import {
|
||||
AttachmentLoader,
|
||||
ImageUploader,
|
||||
@@ -79,6 +80,8 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
|
||||
selector: 'ts-issue-page',
|
||||
changeDetection: ChangeDetectionStrategy.OnPush,
|
||||
imports: [
|
||||
BlockedComponent,
|
||||
ReactionsComponent,
|
||||
MarkdownComponent,
|
||||
MarkdownHintComponent,
|
||||
PasteImagesDirective,
|
||||
@@ -144,19 +147,7 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
|
||||
</a>
|
||||
}
|
||||
@if (issue.blockedBy.length) {
|
||||
<span
|
||||
class="ts-blocked"
|
||||
role="status"
|
||||
[title]="blockedTitle(issue.blockedBy)"
|
||||
>
|
||||
<pi-icon icon="lock" size="x-small" aria-hidden="true" />
|
||||
Bloqueado por
|
||||
@for (blocker of issue.blockedBy; track blocker.id) {
|
||||
<a class="ts-key" [routerLink]="['..', blocker.key]">{{
|
||||
blocker.key
|
||||
}}</a>
|
||||
}
|
||||
</span>
|
||||
<ts-blocked [blockers]="issue.blockedBy" />
|
||||
}
|
||||
</div>
|
||||
<div class="ts-issue__title-row">
|
||||
@@ -634,50 +625,14 @@ const MAX_FILE_BYTES = 25 * 1024 * 1024;
|
||||
!comment.deleted &&
|
||||
(comment.reactions.length || project.myRole())
|
||||
) {
|
||||
<div class="ts-reactions">
|
||||
@for (
|
||||
reaction of comment.reactions;
|
||||
track reaction.emoji
|
||||
) {
|
||||
<button
|
||||
type="button"
|
||||
class="ts-reaction"
|
||||
[class.is-mine]="reacted(reaction)"
|
||||
[attr.aria-pressed]="reacted(reaction)"
|
||||
[title]="reactionTitle(reaction)"
|
||||
[disabled]="!project.myRole()"
|
||||
(click)="
|
||||
facade.react(
|
||||
comment.id,
|
||||
reaction.emoji,
|
||||
!reacted(reaction)
|
||||
)
|
||||
"
|
||||
>
|
||||
{{ reaction.emoji }}
|
||||
<span class="ts-mono">{{
|
||||
reaction.users.length
|
||||
}}</span>
|
||||
</button>
|
||||
}
|
||||
@if (project.myRole()) {
|
||||
<details class="ts-reaction-picker">
|
||||
<summary title="Reaccionar" aria-label="Reaccionar">
|
||||
<pi-icon icon="add" size="x-small" />
|
||||
</summary>
|
||||
<div class="ts-reaction-picker__menu">
|
||||
@for (emoji of reactions; track emoji) {
|
||||
<button
|
||||
type="button"
|
||||
(click)="pickReaction(comment, emoji, $event)"
|
||||
>
|
||||
{{ emoji }}
|
||||
</button>
|
||||
}
|
||||
</div>
|
||||
</details>
|
||||
}
|
||||
</div>
|
||||
<ts-reactions
|
||||
[reactions]="comment.reactions"
|
||||
[me]="facade.me()"
|
||||
[canReact]="!!project.myRole()"
|
||||
(react)="
|
||||
facade.react(comment.id, $event.emoji, $event.on)
|
||||
"
|
||||
/>
|
||||
}
|
||||
@if (!comment.deleted && filesOf(comment).length) {
|
||||
<div class="ts-attachments">
|
||||
@@ -1194,30 +1149,6 @@ export class IssuePage {
|
||||
() => this.facade.comments().filter((c) => !c.deleted).length,
|
||||
);
|
||||
protected readonly commentFiles = signal<File[]>([]);
|
||||
protected readonly reactions = REACTIONS;
|
||||
|
||||
protected reacted(reaction: { users: { id: string }[] }): boolean {
|
||||
return reaction.users.some((u) => u.id === this.facade.me());
|
||||
}
|
||||
|
||||
protected reactionTitle(reaction: {
|
||||
emoji: string;
|
||||
users: { name: string }[];
|
||||
}): string {
|
||||
return `${reaction.users.map((u) => u.name).join(', ')} · ${reaction.emoji}`;
|
||||
}
|
||||
|
||||
/** From the picker: adds it, or takes it back if it was already there. */
|
||||
protected pickReaction(comment: Comment, emoji: string, event: Event): void {
|
||||
const mine = comment.reactions.find((r) => r.emoji === emoji);
|
||||
this.facade.react(comment.id, emoji, !(mine && this.reacted(mine)));
|
||||
(event.target as HTMLElement).closest('details')?.removeAttribute('open');
|
||||
}
|
||||
|
||||
protected blockedTitle(blockers: { key: string; title: string }[]): string {
|
||||
return blockers.map((b) => `${b.key}: ${b.title}`).join('\n');
|
||||
}
|
||||
|
||||
protected duplicate(): void {
|
||||
this.facade.duplicate().subscribe({
|
||||
next: (key) => {
|
||||
@@ -1285,8 +1216,24 @@ export class IssuePage {
|
||||
protected readonly maxFileBytes = MAX_FILE_BYTES;
|
||||
|
||||
/** Files on the ticket itself; those under a comment are shown there. */
|
||||
/** Files shown inside the description or a comment (pasted images). */
|
||||
private readonly inlineFiles = computed(() => {
|
||||
const texts = [
|
||||
this.facade.issue()?.description ?? '',
|
||||
...this.facade.comments().map((c) => c.body),
|
||||
].join('\n');
|
||||
return new Set(
|
||||
[...texts.matchAll(/\(attachment:([\w-]{1,64})\)/g)].map((m) => m[1]),
|
||||
);
|
||||
});
|
||||
/** The ticket's own files, not the ones already shown inside a text. */
|
||||
protected readonly ticketFiles = computed(
|
||||
() => this.facade.issue()?.attachments.filter((a) => !a.commentId) ?? [],
|
||||
() =>
|
||||
this.facade
|
||||
.issue()
|
||||
?.attachments.filter(
|
||||
(a) => !a.commentId && !this.inlineFiles().has(a.id),
|
||||
) ?? [],
|
||||
);
|
||||
protected filesOf = (comment: Comment): Attachment[] =>
|
||||
this.facade
|
||||
|
||||
Reference in New Issue
Block a user