feat: public projects, project deletion and sagas
Public projects:
- Project.isPublic (create/update, owners and admins). Anyone can read a
public project without a token: project, board, tickets, comments,
history, releases, activity, tracking and statistics, over GraphQL and
REST. Writes stay for members (401 anonymous, 403 outsiders).
- @OptionalAuth() / @ApiOptionalPireonAuth(): anonymous callers allowed,
invalid tokens still rejected. ReadAccess lets anonymous viewers read
public projects only; linked tickets are filtered by visibility.
- publicProjects (GraphQL) and GET /api/explore/projects (REST).
- Web: «Explorar» page, project pages open without a session (read-only
notice, sign-in hints), public badge, visibility switch in settings,
no realtime subscriptions without a session.
Project deletion:
- Owner only, confirming the key (deleteProject / DELETE
/api/projects/{project}?confirm=KEY). The key is freed; the read model
drops the project and members are notified (web goes home).
Sagas (run by the EventsBridge after projections, durable and ordered):
- ProjectDeletionSaga: project deleted → delete its tickets and releases;
ticket deleted → purge its comments and drop links from other tickets.
- ReleaseArchivedSaga: unfinished tickets leave an archived release.
- UserDeactivatedSaga: the Pireon webhook records UserDeactivatedEvent in
the event store (EventRecorder); the tracker unassigns that user's open
tickets as the system actor.
- Internal idempotent commands; domain refusals are logged and skipped,
concurrency conflicts retried. Affected streams come from the event store
(TrackerStreamsRepository).
Tests: domain lifecycle specs, saga specs run like the bridge, facade
tests, e2e for public access, cascade deletion, archived releases and
deactivation webhook. Docs, READMEs, schema.gql/openapi.json and Word/PDF
updated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -2,7 +2,8 @@ import { Query } from '@nestjs/cqrs';
|
||||
|
||||
export class CanViewProjectQuery extends Query<boolean> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly projectId: string,
|
||||
) {
|
||||
super();
|
||||
|
||||
@@ -3,7 +3,8 @@ import { ActivityReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
export class GetActivityQuery extends Query<ActivityReadModel[]> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly projectId: string,
|
||||
public readonly issueId?: string,
|
||||
public readonly limit = 50,
|
||||
|
||||
@@ -12,7 +12,8 @@ export interface BoardColumn {
|
||||
/** Kanban board: one column per status of the project (cancelled ones aside). */
|
||||
export class GetBoardQuery extends Query<BoardColumn[]> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly filter: Omit<IssueFilter, 'statuses' | 'limit' | 'offset'>,
|
||||
public readonly perColumn = 50,
|
||||
) {
|
||||
|
||||
@@ -4,7 +4,8 @@ import { Page } from '../ports/find-issues.repository';
|
||||
|
||||
export class GetCommentsQuery extends Query<Page<CommentReadModel>> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly issueId: string,
|
||||
public readonly limit = 50,
|
||||
public readonly offset = 0,
|
||||
|
||||
@@ -3,7 +3,8 @@ import { IssueReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
export class GetIssueQuery extends Query<IssueReadModel> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
/** Issue id or key ("TS-42"). */
|
||||
public readonly idOrKey: string,
|
||||
) {
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
import { IQueryHandler, QueryHandler } from '@nestjs/cqrs';
|
||||
import { IssueReadModel } from '@task-stream/api/tracker/domain';
|
||||
import { FindIssuesRepository } from '../ports/find-issues.repository';
|
||||
import { FindProjectsRepository } from '../ports/find-projects.repository';
|
||||
import { ReadAccess } from './read-access';
|
||||
import { GetIssuesByIdsQuery } from './get-issues-by-ids.query';
|
||||
|
||||
@QueryHandler(GetIssuesByIdsQuery)
|
||||
@@ -10,14 +10,19 @@ export class GetIssuesByIdsQueryHandler
|
||||
{
|
||||
constructor(
|
||||
private readonly findIssues: FindIssuesRepository,
|
||||
private readonly findProjects: FindProjectsRepository,
|
||||
private readonly access: ReadAccess,
|
||||
) {}
|
||||
|
||||
async execute(query: GetIssuesByIdsQuery): Promise<IssueReadModel[]> {
|
||||
const issues = await this.findIssues.findByIds([...new Set(query.ids)]);
|
||||
const visible = new Set(
|
||||
(await this.findProjects.findByMember(query.viewerId)).map((p) => p.id),
|
||||
);
|
||||
return issues.filter((issue) => visible.has(issue.projectId));
|
||||
// Linked tickets may sit in other projects: keep the ones the viewer can read.
|
||||
const visible = new Map<string, boolean>();
|
||||
for (const projectId of new Set(issues.map((issue) => issue.projectId))) {
|
||||
visible.set(
|
||||
projectId,
|
||||
await this.access.canView(projectId, query.viewerId),
|
||||
);
|
||||
}
|
||||
return issues.filter((issue) => visible.get(issue.projectId));
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3,7 +3,8 @@ import { IssueReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
export class GetIssuesByIdsQuery extends Query<IssueReadModel[]> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly ids: string[],
|
||||
) {
|
||||
super();
|
||||
|
||||
@@ -4,7 +4,8 @@ import { ProjectAnalyticsReadModel } from '@task-stream/api/tracker/domain';
|
||||
/** Statistics of a project over the last `days` days. */
|
||||
export class GetProjectAnalyticsQuery extends Query<ProjectAnalyticsReadModel> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly projectId: string,
|
||||
public readonly days: number,
|
||||
) {
|
||||
|
||||
@@ -3,7 +3,8 @@ import { ProjectStatsReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
export class GetProjectStatsQuery extends Query<ProjectStatsReadModel> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly projectId: string,
|
||||
) {
|
||||
super();
|
||||
|
||||
@@ -3,7 +3,8 @@ import { ProjectReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
export class GetProjectQuery extends Query<ProjectReadModel> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
/** Project id or key ("TS"). */
|
||||
public readonly idOrKey: string,
|
||||
) {
|
||||
|
||||
@@ -0,0 +1,15 @@
|
||||
import { IQueryHandler, QueryHandler } from '@nestjs/cqrs';
|
||||
import { ProjectReadModel } from '@task-stream/api/tracker/domain';
|
||||
import { FindProjectsRepository } from '../ports/find-projects.repository';
|
||||
import { GetPublicProjectsQuery } from './get-public-projects.query';
|
||||
|
||||
@QueryHandler(GetPublicProjectsQuery)
|
||||
export class GetPublicProjectsQueryHandler
|
||||
implements IQueryHandler<GetPublicProjectsQuery, ProjectReadModel[]>
|
||||
{
|
||||
constructor(private readonly findProjects: FindProjectsRepository) {}
|
||||
|
||||
execute(): Promise<ProjectReadModel[]> {
|
||||
return this.findProjects.findPublic();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,5 @@
|
||||
import { Query } from '@nestjs/cqrs';
|
||||
import { ProjectReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
/** Projects anyone can read (no sign-in needed). */
|
||||
export class GetPublicProjectsQuery extends Query<ProjectReadModel[]> {}
|
||||
@@ -4,7 +4,8 @@ import { ReleaseBurnupReadModel } from '@task-stream/api/tracker/domain';
|
||||
/** Scope vs finished tickets of a release, day by day. */
|
||||
export class GetReleaseBurnupQuery extends Query<ReleaseBurnupReadModel> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly releaseId: string,
|
||||
) {
|
||||
super();
|
||||
|
||||
@@ -3,7 +3,8 @@ import { ReleaseProgressReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
export class GetReleaseProgressQuery extends Query<ReleaseProgressReadModel> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly releaseId: string,
|
||||
) {
|
||||
super();
|
||||
|
||||
@@ -3,7 +3,8 @@ import { ReleaseReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
export class GetReleaseQuery extends Query<ReleaseReadModel> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly releaseId: string,
|
||||
) {
|
||||
super();
|
||||
|
||||
@@ -3,7 +3,8 @@ import { ReleaseReadModel } from '@task-stream/api/tracker/domain';
|
||||
|
||||
export class GetReleasesQuery extends Query<ReleaseReadModel[]> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly projectId: string,
|
||||
) {
|
||||
super();
|
||||
|
||||
@@ -15,3 +15,4 @@ export * from './get-releases.query';
|
||||
export * from './get-upcoming-releases.query';
|
||||
export * from './search-issues.query';
|
||||
export * from './search-my-issues.query';
|
||||
export * from './get-public-projects.query';
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
import { GetPublicProjectsQueryHandler } from './get-public-projects.query-handler';
|
||||
import { CanViewProjectQueryHandler } from './can-view-project.query-handler';
|
||||
import { GetActivityQueryHandler } from './get-activity.query-handler';
|
||||
import { GetBoardQueryHandler } from './get-board.query-handler';
|
||||
@@ -17,6 +18,7 @@ import { SearchIssuesQueryHandler } from './search-issues.query-handler';
|
||||
import { SearchMyIssuesQueryHandler } from './search-my-issues.query-handler';
|
||||
|
||||
export const QUERY_HANDLERS = [
|
||||
GetPublicProjectsQueryHandler,
|
||||
CanViewProjectQueryHandler,
|
||||
GetActivityQueryHandler,
|
||||
GetBoardQueryHandler,
|
||||
|
||||
@@ -3,23 +3,38 @@ import { NotFoundError } from '@task-stream/api/shared/domain';
|
||||
import { ProjectRole } from '@task-stream/api/tracker/domain';
|
||||
import { FindProjectsRepository } from '../ports/find-projects.repository';
|
||||
|
||||
/** Authorisation for the read side, based on the projected memberships. */
|
||||
/**
|
||||
* Authorisation for the read side, based on the projected memberships:
|
||||
* members read their projects; anyone (also anonymous, `viewerId` null)
|
||||
* reads public ones.
|
||||
*/
|
||||
@Injectable()
|
||||
export class ReadAccess {
|
||||
constructor(private readonly findProjects: FindProjectsRepository) {}
|
||||
|
||||
/** The viewer's role, or null when they read a public project as an outsider. */
|
||||
async assertCanView(
|
||||
projectId: string,
|
||||
viewerId: string,
|
||||
): Promise<ProjectRole> {
|
||||
const role = await this.findProjects.findRole(projectId, viewerId);
|
||||
viewerId: string | null,
|
||||
): Promise<ProjectRole | null> {
|
||||
const role = viewerId
|
||||
? await this.findProjects.findRole(projectId, viewerId)
|
||||
: null;
|
||||
if (role) return role;
|
||||
const project = await this.findProjects.findById(projectId);
|
||||
// Same answer for "doesn't exist" and "not yours": don't leak projects.
|
||||
if (!role) throw new NotFoundError('Project', projectId);
|
||||
return role;
|
||||
if (!project?.isPublic) throw new NotFoundError('Project', projectId);
|
||||
return null;
|
||||
}
|
||||
|
||||
async canView(projectId: string, viewerId: string): Promise<boolean> {
|
||||
return (await this.findProjects.findRole(projectId, viewerId)) !== null;
|
||||
async canView(projectId: string, viewerId: string | null): Promise<boolean> {
|
||||
try {
|
||||
await this.assertCanView(projectId, viewerId);
|
||||
return true;
|
||||
} catch (error) {
|
||||
if (error instanceof NotFoundError) return false;
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
|
||||
assertFound<T>(value: T | null, entity: string, id: string): T {
|
||||
|
||||
@@ -4,7 +4,8 @@ import { IssueFilter, Page } from '../ports/find-issues.repository';
|
||||
|
||||
export class SearchIssuesQuery extends Query<Page<IssueReadModel>> {
|
||||
constructor(
|
||||
public readonly viewerId: string,
|
||||
/** Null: anonymous (public projects only). */
|
||||
public readonly viewerId: string | null,
|
||||
public readonly filter: IssueFilter,
|
||||
) {
|
||||
super();
|
||||
|
||||
Reference in New Issue
Block a user